Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] JGit Questions and Build

On Thu, Oct 1, 2009 at 4:17 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
Chris Aniszczyk <zx@xxxxxxxxxxxxxxxxx> wrote:
> When looking at the JGit library, I noticed that there was a
> "org.eclipse.jgit.awtui" package...
>
> Is that intentional?

Yes.  Its common AWT based UI code for any consumer of JGit who is
using an AWT UI.

> Do we want to have UI bits in the core JGit library?

Well, it should be a side library, not part of the core plugin.

> Should we have a org.eclipse.jgit.core and org.eclipse.jgit.ui split?

Yes.

Create a bug for this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=291124
 
> Are there packages in JGit that are meant to be "internal" ? What does JGit
> consider API?

None are really internal yet.  Classes that are only package visible
are internal, but other than that any public class is part of our
current public API.

To make this more "OSGi" friendly we will figure out what to make public API and x-internal.

We have some freedom now given that the project isn't "1.0" and API can change.
 

> Once I have the feature for JGit, I can setup a releng project.
>
> I volunteer to be the releng person for JGit/EGit to save people the
> trouble. If people think this is worth committership feel free to nominate
> me.

FYI, over on the Git mailing list there is also work going on to
cleanup the build to be Maven based:

 http://article.gmane.org/gmane.comp.version-control.git/129410

Cool, I'm sure we can do something as part of the build at Eclipse to ensure things are Maven friendly. There's been some discussion at Eclipse on how to make this happen:
     https://bugs.eclipse.org/bugs/show_bug.cgi?id=283745

If people have no problem in me doing the releng stuff, a EGit committer can do the nomination from http://portal.eclipse.org

Cheers, 

--
Chris Aniszczyk | EclipseSource Austin | +1 860 839 2465
http://twitter.com/eclipsesource | http://twitter.com/caniszczyk

Back to the top