[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: EMF backed Workbench (Was Re: [eclipse-incubator-e4-dev] Initial discussion on the 'modelled' workbench UI)
|
Hi,
Beautiful work Tom! I liked a lot what I am seeing here. I have 2
suggestions and a request ;-)
1. I saw a few attributes using EBooleanObject as type (ESash.horizontal
for example). I am wondering if they could be just EBoolean (ie, the
primitive type)
2. I don't believe we should get too much into optimization at this very
moment, but since we are talking about booleans ;-) , there is a very
simple change you can make to reduce the amount of memory used to store
boolean values. In your genmodel, select the root node and set the
following properties as indicated
"Model Feature Defaults -> Boolean Flag Fields" : eFlags
"Model Feature Defaults -> Boolean Flag Reserved Bits " : 8
When you regen the code, the boolean values will be stored using the bits
available in EObjectImpl.eFlag instead of actual boolean variables. The
accessors will take care of all the nasty bitwise operations for you :-)
3. Can you export the packages declared in
"org.eclipse.e4.presentationmodel.pure.emf.workbench"? I would like to
play with the classes available there, to leverage the technology already
available for EMF models to this example.
Cheers,
Marcelo Paternostro
IBM Toronto Lab
1-905-413-3942
marcelop@xxxxxxxxxx
From: Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>
To: E4 developer list <eclipse-incubator-e4-dev@xxxxxxxxxxx>
Date: 04/09/2008 06:11 PM
Subject: EMF backed Workbench (Was Re: [eclipse-incubator-e4-dev] Initial discussion on the 'modelled' workbench UI)
Hi,
I finally managed to get the workbench up and running with an EMF-Model
implementation in the background.
You can fetch the 2 necessary projects from [1]. The current state of my
implementation is that the workbench shows up and is backed by an
EMF-Model not more not less. I looks and behaves different than it
should and I'm going to investigate this in the next days but at least I
have now reached a point where I can investigate because the workbench
starts :-)
One thing I'd like to point out explicitly here too: Please read the
note I added to the bug to understand where I'm coming from and where I
try to go to.
Tom
[1]https://bugs.eclipse.org/bugs/show_bug.cgi?id=226379
--
B e s t S o l u t i o n . a t EDV Systemhaus GmbH
------------------------------------------------------------------------
tom schindl leiter softwareentwicklung/CSO
------------------------------------------------------------------------
eduard-bodem-gasse 8/3 A-6020 innsbruck phone ++43 512 935834
_______________________________________________
eclipse-incubator-e4-dev mailing list
eclipse-incubator-e4-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse-incubator-e4-dev
