Re: [e4-dev] RC3 rules of engagement.

[Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>]

Hi,

I've already committed many fixes to my ModelTooling stuff:
* adding support for new introduced type Category
* complete NLS suppport
* fixes for e4 Wizard to work on all platforms
* validation to avoid wrong Keysquences
* restructuring of move as an add/remove (to satisfy the renderers)

on the weekend. My problem is and was that I'm only having time to work
on this larger things on the weekend and waiting for a review is not
really helping me to get those important things done (if we only could
already have git :-).

For code changes on the 4.0 SDK and e4 core stuff I've been following
the rule. I'll try to dial in to the todays meeting but can't promise so
here's my bug queue for rc3:
* P1 - 320235: NPE if delta.xml exists
  (which already has patches but needs review from others)

* P1 - 320249: Switching tabs with Ctrl+PgUp/Down doesn't grant focus
               to the part's control
  (has patch but needs review)

* P2 - 320239: View Toolbar Icons are clipped
  (though I have no idea where to start searching) but this is on
  Ubuntu an often used Desktop Linux

* P3 - 319463: Remove dead code

Tom

Am 20.07.10 06:52, schrieb Boris Bokowski:
> Paul Webster wrote on 2010/07/19 20:23:07:
> 
>> OK, now that we're in RC3, we need two +1s to make the fix (and
>> technically 2 committers must code review)
>> ...
>>
>> Boris, is this what we want to do?
> 
> How about: at least one review from another committer, and a +1 from
> Susan, McQ, John, or me. All of this prior to checking in the change.
> 
> I suggest we use the Platform UI meeting (Tuesday 11 am Eastern, see
> http://wiki.eclipse.org/Platform_UI) to coordinate which bugs we will be
> working on.
> 
> We probably need rules for changes after RC3 as well, I would suggest:
> two code reviews from other committers, and PMC approval (likely McQ or
> John).
> 
> Boris
> 
> 
> 
> _______________________________________________
> e4-dev mailing list
> e4-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/e4-dev


-- 
B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
------------------------------------------------------------------------
tom schindl                                        geschaeftsfuehrer/CEO
------------------------------------------------------------------------
eduard-bodem-gasse 5/1    A-6020 innsbruck      phone    ++43 512 935834