[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [dsdp-tm-dev] Review: Changes in org.eclipse.rse.files.ui
|
No problem. As you point out, the icu.lang was a holdover and should
have been removed. I left the version numbers in because I was aware
that previous versions of icu4j had some problems with Japanese.
However, if the platform is not specifying this version then we
certainly don't need to.
-- Dave
On May 29, 2007, at 2:28 PM, Oberhuber, Martin wrote:
Hi Dave,
I just reviewed your changes for using ICU in
org.eclipse.rse.files.ui, and I think I found
some problems:
1. In MANIFEST.MF, you import com.ibm.icu.lang
but it looks like you use com.ibm.icu.text
only. Please don't import-package stuff you
don't need.
2. In MANIFEST.MF, please don't use a fixed
version=tag with Import-Package. The platform
also doesn't use it.
I made the changes for you, and I hope you approve.
Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
_______________________________________________
dsdp-tm-dev mailing list
dsdp-tm-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
