Hi Roy,
As I see in HEAD code are not commented (revision 1.15).
In revision 1.14 commented code was because of work over bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=280237
But caused incorrect completion for TCL for multiple projects with different environments, so we returned it to 1.13 state.
Best regards,
Andrei Sobolev.
----- Original Message -----
From: "Roy Ganor" <roy@xxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
Sent: Sunday, August 30, 2009 9:59:50 PM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] checkScope in HandleFactory
Hi,
In the HadnleFactory class a code that was responsible to filter
out projects according to the specified scope was commented out.
Any chance you know what the cause of this change? types with a wrong
project get priority over the real types…
Regards,
Roy
###
Eclipse Workspace Patch 1.0
Index:
model/org/eclipse/dltk/internal/core/util/HandleFactory.java
===================================================================
RCS
file: /cvsroot/technology/org.eclipse.dltk/core/plugins/org.eclipse.dltk.core/model/org/eclipse/dltk/internal/core/util/HandleFactory.java,v
diff
-u -r1.14 HandleFactory.java
---
model/org/eclipse/dltk/internal/core/util/HandleFactory.java 16 Jun 2009 13:38:01 -0000 1.14
+++
model/org/eclipse/dltk/internal/core/util/HandleFactory.java 30 Aug 2009 14:51:21 -0000
IPath
path = Path.fromPortableString(pathString);
IProject[]
projects = getAllProjects();
- //
IPath[] enclosingProjectsAndZips = scope.enclosingProjectsAndZips();
+ IPath[]
enclosingProjectsAndZips = scope.enclosingProjectsAndZips();
for
(int i = 0, max = projects.length; i < max; i++) {
IProject
project = projects[i];
- //
if (!checkScope(project, enclosingProjectsAndZips)) {
+ if
(!checkScope(project, enclosingProjectsAndZips)) {
if
(!project.isAccessible()
||
!DLTKLanguageManager.hasScriptNature(project))
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev