RE: [Dltk-dev] checkScope in HandleFactory

["Vadim Punski" <vadim.p@xxxxxxxx>]

Hi Andrei,

Comment added to the bug report mention below.

Just want to elaborate, that much simpler case (again, described in the bug), based on project scope search with exact match rule doesn’t work anymore.

No way to increase the priority of the bug, because it has a “blocker” status already.

 

Regards,

                Vadim

 

From: dltk-dev-bounces@xxxxxxxxxxx [mailto:dltk-dev-bounces@xxxxxxxxxxx] On Behalf Of andrei.sobolev@xxxxxxxxx
Sent: Monday, August 31, 2009 5:59 AM
To: DLTK Developer Discussions
Subject: Re: [Dltk-dev] checkScope in HandleFactory

 

Hi Roy,

As I see in HEAD code are not commented (revision 1.15).
In revision 1.14 commented code was because of work over bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=280237
But caused incorrect completion for TCL for multiple projects with different environments, so we returned it to 1.13 state.

Best regards,
Andrei Sobolev.

----- Original Message -----
From: "Roy Ganor" <roy@xxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
Sent: Sunday, August 30, 2009 9:59:50 PM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] checkScope in HandleFactory

Hi,

In the HadnleFactory class a code that was responsible to filter out projects according to the specified scope was commented out.

Any chance you know what the cause of this change? types with a wrong project get priority over the real types…

 

Regards,

Roy

 

### Eclipse Workspace Patch 1.0

#P org.eclipse.dltk.core

Index: model/org/eclipse/dltk/internal/core/util/HandleFactory.java

===================================================================

RCS file: /cvsroot/technology/org.eclipse.dltk/core/plugins/org.eclipse.dltk.core/model/org/eclipse/dltk/internal/core/util/HandleFactory.java,v

retrieving revision 1.14

diff -u -r1.14 HandleFactory.java

--- model/org/eclipse/dltk/internal/core/util/HandleFactory.java     16 Jun 2009 13:38:01 -0000  1.14

+++ model/org/eclipse/dltk/internal/core/util/HandleFactory.java     30 Aug 2009 14:51:21 -0000

@@ -317,13 +317,13 @@

 

           IPath path = Path.fromPortableString(pathString);

           IProject[] projects = getAllProjects();

-          // IPath[] enclosingProjectsAndZips = scope.enclosingProjectsAndZips();

+          IPath[] enclosingProjectsAndZips = scope.enclosingProjectsAndZips();

           for (int i = 0, max = projects.length; i < max; i++) {

                try {

                     IProject project = projects[i];

-                    // if (!checkScope(project, enclosingProjectsAndZips)) {

-                    // continue;

-                    // }

+                    if (!checkScope(project, enclosingProjectsAndZips)) {

+                          continue;

+                    }

                     if (!project.isAccessible()

                                || !DLTKLanguageManager.hasScriptNature(project))

                           continue;

 

_______________________________________________ dltk-dev mailing list dltk-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dltk-dev