[Dltk-dev] checkScope in HandleFactory

["Roy Ganor" <roy@xxxxxxxx>]

Hi,

In the HadnleFactory class a code that was responsible to filter out projects according to the specified scope was commented out.

Any chance you know what the cause of this change? types with a wrong project get priority over the real types…

 

Regards,

Roy

 

### Eclipse Workspace Patch 1.0

#P org.eclipse.dltk.core

Index: model/org/eclipse/dltk/internal/core/util/HandleFactory.java

===================================================================

RCS file: /cvsroot/technology/org.eclipse.dltk/core/plugins/org.eclipse.dltk.core/model/org/eclipse/dltk/internal/core/util/HandleFactory.java,v

retrieving revision 1.14

diff -u -r1.14 HandleFactory.java

--- model/org/eclipse/dltk/internal/core/util/HandleFactory.java     16 Jun 2009 13:38:01 -0000  1.14

+++ model/org/eclipse/dltk/internal/core/util/HandleFactory.java     30 Aug 2009 14:51:21 -0000

@@ -317,13 +317,13 @@

 

           IPath path = Path.fromPortableString(pathString);

           IProject[] projects = getAllProjects();

-          // IPath[] enclosingProjectsAndZips = scope.enclosingProjectsAndZips();

+          IPath[] enclosingProjectsAndZips = scope.enclosingProjectsAndZips();

           for (int i = 0, max = projects.length; i < max; i++) {

                try {

                     IProject project = projects[i];

-                    // if (!checkScope(project, enclosingProjectsAndZips)) {

-                    // continue;

-                    // }

+                    if (!checkScope(project, enclosingProjectsAndZips)) {

+                          continue;

+                    }

                     if (!project.isAccessible()

                                || !DLTKLanguageManager.hasScriptNature(project))

                           continue;