Re: [Dltk-dev] Dynamic handling of DLTK contributors

[Andrey Platov <andrey@xxxxxxxxx>]

Hi William,

Thank you for the patch! I'd suggest you to contribute the patch to  
eclipse bugzilla at least for the reasons below:

1) You'll be able to track patch status as well as discuss potential  
issues with other committers
2) As per eclipse development process contributions from non- 
committers should be recorded in the project IP log (with references  
to bugzilla entry)
3) Records of code contributions to the project, which are visible to  
community, is an essential part of committer nomination process (of  
course if you'd have an intention to become a committer on the project)

Thank you very much, and
Kind Regards,
Andrey

On Apr 25, 2009, at 10:13 PM, William Candillon wrote:

> Hello Andrey,
>
> Please find enclosed the patch. It covers my showcase very well.
> Unfortunately it works only with the BuildParticipant extension point
> but that will be cool if on the long run DLTK could support dynamic
> eclipse plugins, one extension point at a time.
>
> I saw on a previous mail that DLTK is about to drop support for java
> 1.4, that would be an awesome opportunity to refactor the
> NatureExtensionManager and the BuildParticipantManager class.
>
> Please keep me in touch on the process to commit this patch.
>
> Best regards,
>
> William
>
> On Thu, Apr 23, 2009 at 1:54 PM, Andrey Platov <andrey@xxxxxxxxx>  
> wrote:
> > Hi William,
> >
> > Nice use case, and thank you for sharing the demo code. Please  
> > submit a
> > patch to bugzilla - it will be committed with a great chance!
> >
> > Kind Regards,
> > Andrey
> >
> > ----- Original Message -----
> > From: "William Candillon" <wcandillon@xxxxxxxxx>
> > To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
> > Sent: Thursday, April 23, 2009 3:28:37 PM GMT +06:00 Almaty,  
> > Novosibirsk
> > Subject: Re: [Dltk-dev] Dynamic handling of DLTK contributors
> >
> > Hello Andrey,
> >
> > It seems to me that people who could really use dynamic loading of
> > JavaScript written bundles are people that are using/contributing
> > DLTK.
> > With e4 support for JavaScript, you can specialize your DLTK
> > environment and fast prototype extensions of DLTK.
> > I wrote a small example of a PHP code analyser extending DLTK and  
> > PDT:
> > http://code.google.com/p/jspde/source/browse/trunk/org.phpaspect.examples/src/PHPStaticAnalysis.js
> >
> > This works great but I cannot load it dynamically. Would it be
> > possible to have a dynamic handling of contributors in the
> > BuildParticipantManager? I would be able to build a show case from
> > there.
> > Loading contributors at load-time works because Eclipse has a special
> > mechanism for that at startup but It doesn't sound right since OSGi
> > bundles are designed to be loaded/removed dynamically.
> >
> > If I send a patch of the
> > BuildParticipantManager/NatureExtensionManager, will it have a good
> > chance to be committed?
> >
> > Best regards,
> >
> > William
> >
> > On Wed, Apr 22, 2009 at 9:18 PM, Andrey Platov <andrey@xxxxxxxxx>  
> > wrote:
> > > Hi William,
> > >
> > > It's definitely possible to add listeners to the extension  
> > > registry, but
> > > for
> > > many extension points this would not be reasonable (no use-cases for
> > > extension of some point to be loaded dynamically); may result  in
> > > performance degradations, etc... and finally such improvement may  
> > > require
> > > significant development efforts...
> > >
> > > However, if you have good use case (your demo) let's think about  
> > > to add
> > > dynamic listening for extensions for your particular use case, and
> > > probably
> > > for other extensions, which may have some practical interest to  
> > > adopters.
> > >
> > > Could you please update us with scenario of your demo, and extension
> > > points
> > > involved?
> > >
> > > Kind Regards,
> > > Andrey
> > >
> > >
> > > On Apr 22, 2009, at 10:50 PM, William Candillon wrote:
> > >
> > > > Hello guys,
> > > >
> > > > I wrote a plugin to support JavaScript written plugins
> > > > (http://code.google.com/p/jspde/).
> > > > One of the feature provided by the plugin is the dynamic loading of
> > > > OSGi bundles:
> > > > http://code.google.com/p/jspde/wiki/LoadingPluginDynamically
> > > >
> > > > As a demo I'm contributing to DLTK extensions points in  
> > > > JavaScript but
> > > > I cannot load these extensions dynamically.
> > > > It seems to me that most of DLTK extensions points are  
> > > > implemented in
> > > > a such way that contributors are fetched once at load-runtime and  
> > > > that
> > > > is it.
> > > > Would it be possible to add listeners to the extension points  
> > > > registry ?
> > > >
> > > > Best regards,
> > > >
> > > > William
> > > >
> > > > --
> > > > William Candillon
> > > > _______________________________________________
> > > > dltk-dev mailing list
> > > > dltk-dev@xxxxxxxxxxx
> > > > https://dev.eclipse.org/mailman/listinfo/dltk-dev
> > >
> > > _______________________________________________
> > > dltk-dev mailing list
> > > dltk-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/dltk-dev
> >
> >
> >
> > --
> > William Candillon
> > _______________________________________________
> > dltk-dev mailing list
> > dltk-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/dltk-dev
>
>
>
> --
> William Candillon
> <nature_manager.patch>