Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [dali-dev] changing jpaPlatform extension points

I vote for 'jpaPlatform' over 'jpaPlatformId'. Suffixes are nice when dealing with
objects, but often seem redundant when dealing with text.

Brian

Paul Fullbright wrote:
I would add, however, if this field were to eventually move to represent a platform version, jpaPlatformId might be misleading, as it would be an id *and* a version.  Alternatively we could just add a version field as well.

But I also add that an id is somewhat superfluous here.  We don't use "className" everywhere you specify a class for the same reason, because you know that the name is what you use to specify a class.

Paul

Neil Hauge wrote:
I like changing the ui extension to "jpaPlatformUi".  It seems more consistent with the code, and more obvious to the extender.  I think I prefer "jpaPlatformId" field, since it syntactically matches the expected value from the core jpaPlatform "id" field, and I don't mind verboseness for clarity in extension definitions. 

Just my opinion.

Neil

Karen Moore wrote:
Paul Fullbright wrote:
Also (and I know this is late - sorry) I think we should change the ui extension to "jpaPlatformUi" and the field "jpaPlatformId" to just "jpaPlatform".
If we're going to change this in 2.2, we need to go ahead and change it in M5.

Karen


- Paul

Karen Moore wrote:
I have checked these changes in, the bug explains the changes that were made.  This will be in the 2.2M5 release and includes changing the names of the extension points.  I am assuming community silence means consent to the changes :)

thanks,
Karen

Karen Moore wrote:

Hi,

I am looking at https://bugs.eclipse.org/226570 and changing the core.jpaPlatform and ui.jpaPlatform extension points.  The bug explains the couple of changes I plan to make and includes an attachment.  This is being done in our effort to support multiple JPA versions in the future.  Sending this out so extenders know they will have to react in 2.2M5 and so we can discuss if the changes make sense.  Beyond the patch attached to the bug I am trying to determine if the extension point name or jpaPlatform element name should change as well.

   <extension point="org.eclipse.jpt.core.jpaPlatform">
       <jpaPlatform
           id="generic"
           label="%GENERIC_PLATFORM_LABEL"
           factoryClass="org.eclipse.jpt.core.internal.platform.GenericJpaPlatformFactory"
           default="false"/>
   </extension>

   <extension point="org.eclipse.jpt.ui.jpaPlatform">
       <jpaPlatform
           id="generic.ui"
           jpaPlatformId="generic"
           factoryClass="org.eclipse.jpt.ui.internal.platform.generic.GenericJpaPlatformUiFactory"/>
   </extension>

I have noticed other extension points tend to be plural, but not sure there is really a pattern there.  Also, is there a better name for the element jpaPlatform?  Potentially jpaPlatformFactory/jpaPlatformUiFactory and then the factoryClass attribute would be renamed to class.  I am not completely sold on this idea since the attributes specified in jpaPlatformFactory really pertain to the platform not the factory.  I am looking for suggestions here.

Thanks,
Karen
_______________________________________________
dali-dev mailing list
dali-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dali-dev

_______________________________________________
dali-dev mailing list
dali-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dali-dev


-- 
Paul Fullbright
Eclipse Java Persistence Tools (Dali) Development
Oracle

_______________________________________________ dali-dev mailing list dali-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dali-dev

_______________________________________________ dali-dev mailing list dali-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dali-dev


_______________________________________________ dali-dev mailing list dali-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dali-dev


-- 
Paul Fullbright
Eclipse Java Persistence Tools (Dali) Development
Oracle

_______________________________________________ dali-dev mailing list dali-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dali-dev


Back to the top