Re: [cdt-dev] Ping review

[marco <marco.stornelli@xxxxxxxxx>]

There are a couple of commits where I needed to duplicate the code like 
in the commits for bugs 545714 and 545959. Codan commits are in 
conflicts each other due to the tests and the same for all commits of 
formatter.

In addition it seems we have a major problem with CDT bot every commit 
is failing due this error:

[ERROR] Failed to execute goal 
org.eclipse.tycho.extras:tycho-p2-extras-plugin:1.3.0:compare-version-with-baselines 
(compare-attached-artifacts-with-release) on project 
org.eclipse.cdt.core.native: Execution 
compare-attached-artifacts-with-release of goal 
org.eclipse.tycho.extras:tycho-p2-extras-plugin:1.3.0:compare-version-with-baselines 
failed:

Failed to load p2 repository from location 
https://ci.eclipse.org/cdt/job/cdt-9.7/3/artifact/releng/org.eclipse.cdt.repo/target/repository/: 
No repository found at 
https://ci.eclipse.org/cdt/job/cdt-9.7/3/artifact/releng/org.eclipse.cdt.repo/target/repository. 
-> [Help 1]

Il 02/04/19 22:00, Jeff Johnston ha scritto:
> I was referring to posting the following:
>
> https://git.eclipse.org/r/#/q/marco.stornelli
>
> If you want to point to specific patches first, feel free.
>
> On Tue, Apr 2, 2019 at 3:22 PM Mark B <marco.stornelli@xxxxxxxxx 
> <mailto:marco.stornelli@xxxxxxxxx>> wrote:
>
>     If you are talking about the list of commits they are just on Gerrit
>     waiting for review. Some of them are quite trivial, especially some
>     on formatter, some needs a deeper review.
>
>     Il mar 2 apr 2019, 21:18 Jeff Johnston <jjohnstn@xxxxxxxxxx
>     <mailto:jjohnstn@xxxxxxxxxx>> ha scritto:
>
>         Hi Marco,
>
>         It might help to add a URL to point to the list so people can
>         easily look at them.  If there are any that are trivial or
>         obvious or
>         are needed by other patches, point them out and try to get them
>         out of the way first.
>
>         -- Jeff J.
>
>
>
>         On Tue, Apr 2, 2019 at 12:31 PM marco <marco.stornelli@xxxxxxxxx
>         <mailto:marco.stornelli@xxxxxxxxx>> wrote:
>
>             Hi guys,
>
>             I've currently got 26 pending commits without any feedback.
>             I think I'm
>             going to stop to fix other things until these commits are
>             accepted or
>             reviewed, too much conflicts and dependencies. I hope
>             someone can take a
>             look soon.
>
>             Regards.
>
>             Marco
>             _______________________________________________
>             cdt-dev mailing list
>             cdt-dev@xxxxxxxxxxx <mailto:cdt-dev@xxxxxxxxxxx>
>             To change your delivery options, retrieve your password, or
>             unsubscribe from this list, visit
>             https://www.eclipse.org/mailman/listinfo/cdt-dev
>
>         _______________________________________________
>         cdt-dev mailing list
>         cdt-dev@xxxxxxxxxxx <mailto:cdt-dev@xxxxxxxxxxx>
>         To change your delivery options, retrieve your password, or
>         unsubscribe from this list, visit
>         https://www.eclipse.org/mailman/listinfo/cdt-dev
>
>     _______________________________________________
>     cdt-dev mailing list
>     cdt-dev@xxxxxxxxxxx <mailto:cdt-dev@xxxxxxxxxxx>
>     To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     https://www.eclipse.org/mailman/listinfo/cdt-dev
>
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/cdt-dev