[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] anyone care about keybinding warnings?

Thanks Marc.  Yes the problem is in 3.8 only and warnings are logged when editor menu is opened, and only when -debug option is specified.

Cheers,
Pawel

On 04/04/2012 12:08 PM, Marc Khouzam wrote:
I think the accelerators are nice to have.
The logs are only at startup right?  I personally think it is ok.
 
Also, is this problem for 4.2 or only 3.8?  If it is only for 3.8, it is even less of an annoyance.
 
my 2 cents
 
Marc
 


From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Pawel Piech
Sent: Wednesday, April 04, 2012 2:30 PM
To: CDT General developers list.
Subject: [cdt-dev] anyone care about keybinding warnings?

Hi All,
I recently added a feature to use key modifiers when double-clicking on editor gutter to edit properties or enable/disable breakpoints (see Bug 360588).  As part of the feature I the accelerator text to the popup menu e.g. "Toggle Breakpoint Enable   Shift+Double Click".  Unfortunately the accelerator text trips up a legacy accelerator logic which tries to parse the label of the menu item.  This logic logs a warning if -debug option is specified when launching the IDE (see Bug 374153 for details.)

IMO, the benefit of seeing this accelerator in menu is worth the tradeoff of the warning.  Platform has a stricter standard so they will not accept this tradeoff, but I can still make it work for CDT only unless the community objects.

Opinions (I'll take silence as sign of approval)?
-Pawel


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev