Re: [cdt-dev] Wiki updates for contributing patches on Git

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

On Fri, Nov 4, 2011 at 12:35 PM, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx> wrote:

Thanks Christian for adding this info!

 

I updated two points on the wiki:

- mentioning that a patch can only be created for a single commit, and therefore to be aware of the "Amend previous commit" option

- mentioning to use the Repository history (as people mistakenly tried to create patches from the file history in some cases).

 

There is one part I'm not sure about.  The wiki recommends not to use the Git format for the patch.

At one point EGit would hit an NPE when creating patches not using the Git format.  Also,

the Git format has the nice advantage of including the commit on which the patch should be applied.

The con is that when applying a Git patch, one must select to ignore the first two path name segments;

but it still works once that is done.  I use Git format all the time now.

 

Should we ask contributors to attach patches in Git format?

Yes. 

 

Marc

-sergey 

 

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Schaefer, Doug
Sent: Friday, November 04, 2011 2:44 PM
To: CDT General developers list.
Subject: Re: [cdt-dev] Wiki updates for contributing patches on Git

Excellent, thanks Christian. We’re all new to it so any info documented is a great help.

 

Cheers,

D

 

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Christian Damus
Sent: Friday, November 04, 2011 2:20 PM
To: cdt-dev@xxxxxxxxxxx
Subject: [cdt-dev] Wiki updates for contributing patches on Git

 

Hi,

 

As I just went through the process as a Git first-timer of cloning the CDT repo, making some changes, and contributing them to the project as a patch on Bugzilla, I thought I'd document the procedure briefly on the Wiki.

• I added a section (#8) to the http://wiki.eclipse.org/CDT/git page outlining the steps I followed and
• I updated the http://wiki.eclipse.org/CDT/contributing page to link to the above, as it was still describing a CVS-ish method.

As I said, I'm new to Git, so I may have done something wrong that will lead others astray.  If so, please correct me (on the Wiki, of course).

 

Cheers,

 

Christian

 

 

----
Christian W. Damus
Software Developer, IDE Team
QNX Software Systems Limited <http://www.qnx.com/>

 

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev