Thanks Christian for adding this info!
I updated two points on the wiki:
- mentioning that a patch can only be created for a single
commit, and therefore to be aware of the "Amend previous commit"
option
- mentioning to use the Repository history (as people
mistakenly tried to create patches from the file history in some
cases).
There is one part I'm not sure about. The wiki
recommends not to use the Git format for the patch.
At one point EGit would hit an NPE when creating patches
not using the Git format. Also,
the Git format has the nice advantage of including the
commit on which the patch should be applied.
The con is that when applying a Git patch, one must select
to ignore the first two path name segments;
but it still works once that is done.
I use Git format all the time now.
Should we ask contributors to attach patches in Git
format?
Marc
Excellent,
thanks Christian. We’re all new to it so any info documented is a great
help.
Cheers,
D
From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf
Of Christian Damus Sent: Friday, November 04, 2011 2:20
PM To: cdt-dev@xxxxxxxxxxx Subject: [cdt-dev] Wiki updates
for contributing patches on Git
Hi,
As I just went through the process as a Git first-timer of
cloning the CDT repo, making some changes, and contributing them to the
project as a patch on Bugzilla, I thought I'd document the procedure briefly
on the Wiki.
As I said, I'm new to Git, so I may have done something
wrong that will lead others astray. If so, please correct me (on the
Wiki, of course).
---- Christian W. Damus Software Developer, IDE Team QNX Software Systems Limited <http://www.qnx.com/>
|