[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [cdt-dev] IPLog question
|
I think that meant to say all patches from committers should be iplog-.
At the end of the release I go through all bugs with patches and make sure the ones marked iplog+ are captured in our log.
If they aren't marked either way I need to take a look at them and determine whether they need to be in the log or not. The fewer of those the better :).
Thanks,
Doug.
On Tue, Mar 16, 2010 at 2:24 PM, Alena Laskavaia
<elaskavaia.cdt@xxxxxxxxx> wrote:
Btw I looked at our policy wiki
(http://wiki.eclipse.org/CDT/policy)
and it has some contradictory
statements
Applying the Patch
...
- Set the iplog+ flag for the committed patch (unless
submitted by Commiter) - See also Development_Resources/Automatic_IP_Log
- Check that all non-committed patches marked as obsolite
- Check that all committed patches are marked iplog-
1st statement here is the opposite of 3rd. How to interpret that?
Doug Schaefer wrote:
At the end of the day, will someone sue us for copying
someone else's IP? If it's pre-existing IP in the CDT, I wouldn't worry
about it.
On Tue, Mar 16, 2010 at 1:25 PM, Marc
Khouzam
<marc.khouzam@xxxxxxxxxxxx>
wrote:
Elena committed the first of the two patches, which contained
most of the work.
I committed the second patch (I guess I should have asked the
question before committing, oops),
but that code is really a bunch of copying of existing code
for UI tabs to have a slightly modified DSF-GDB version.
So, I think this is safe.
As for next time, I'll be more prepared.
Thanks
There's a little bit of a committer judgment
call when it comes to IP review. It seems to me that in this case it's
obvious to you that the outside contribution is < 200 loc. BTW,
another convenient feature is that if the code was written by a
co-worker of committer, than that committer can commit the code without
filing a CQ event if it's > 200 loc. So if Alena was to have
committed the patch, you would also be in the clear.
Cheers,
Pawel
Marc Khouzam wrote:
Hi,
Andy Jin from QNX has contributed a couple of patches for
Jtag debugging for DSF-GDB (yeah!).
Those pathes were more than 250 lines but only because
there was a lot of code copied from other
files of CDT.
What are we supposed to do in those cases?
Thanks
Marc
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev