Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [cdt-dev] IPLog question

Elena committed the first of the two patches, which contained most of the work.
I committed the second patch (I guess I should have asked the question before committing, oops),
but that code is really a bunch of copying of existing code for UI tabs to have a slightly modified DSF-GDB version.
So, I think this is safe.
 
As for next time, I'll be more prepared.
 
Thanks
 


From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Pawel Piech
Sent: March-16-10 1:07 PM
To: CDT General developers list.
Subject: Re: [cdt-dev] IPLog question

There's a little bit of a committer judgment call when it comes to IP review.  It seems to me that in this case it's obvious to you that the outside contribution is < 200 loc.  BTW, another convenient feature is that if the code was written by a co-worker of committer, than that committer can commit the code without filing a CQ event if it's > 200 loc.  So if Alena was to have committed the patch, you would also be in the clear.

Cheers,
Pawel

Marc Khouzam wrote:
Hi,
 
Andy Jin from QNX has contributed a couple of patches for Jtag debugging for DSF-GDB (yeah!).
Those pathes were more than 250 lines but only because there was a lot of code copied from other
files of CDT.
 
What are we supposed to do in those cases?
 
Thanks
 
Marc
 
 

_______________________________________________ cdt-dev mailing list cdt-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top