RE: [cdt-dev] Bug in GeneratedMakefileBuilder.java?

["Treggiari, Leo" <leo.treggiari@xxxxxxxxx>]

Hi Thomas,

I didn't write that code, so I don't know why it doesn't check for
IStatus.ERROR.  Would you enter bugzillas for this and the other
GeneratedMakefileBuilder problem that you found?

Thanks,
Leo

-----Original Message-----
From: cdt-dev-admin@xxxxxxxxxxx [mailto:cdt-dev-admin@xxxxxxxxxxx] On
Behalf Of thomas strehl
Sent: Thursday, February 24, 2005 6:04 AM
To: cdt-dev@xxxxxxxxxxx
Subject: [cdt-dev] Bug in GeneratedMakefileBuilder.java?

Hi,

I found a problem when implementing a new Makefile generator. In
GeneratedMakefileBuilder.java your code calls the custom Makefile
generator: 

(in incrementalBuild)

MultiStatus result = generator.generateMakefiles(delta);
if (result.getCode() == IStatus.WARNING || result.getCode() ==
IStatus.INFO) {
...
}

Is there any reason why there is no check for an error code??? I mean
something like that:

if (result.getCode() == IStatus.ERROR)
    return;

Currently, there is no way to tell the framework that an error occured
during Makefile generation and that the build process should be stopped.
The only way this is possible is, to pass back 'null' as the result and
force an exception in the code above, but this is surely really hacky.

Any comments?


Thomas
__________________________________________________________
Mit WEB.DE FreePhone mit hoechster Qualitaet ab 0 Ct./Min.
weltweit telefonieren! http://freephone.web.de/?mc=021201

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/cdt-dev