Re: [buckminster-dev] buckminster.download.source=true causes failure

[Alan Underwood <forums-noreply@xxxxxxxxxxx>]

Okay, so there is a problem in the ResolverNodeWithJob.buildTree() method, or at least, its dependent objects.
The code loops through the dependencies of the ResolvedNode to create its child queries, which have not got the filter applied to them. The Resolution.cspec.dependencies however, do have the eclipse.p2.optional filter set. So I guess there is a problem where the cspec is having the .source plug-in dependency added with filter, but the Resolved node is not including that filter when it adds those plug-in dependencies.

Then when the ResourceMap.resolve() method calls request.isOptional(), having failed to resolve the .source plug-in, the ComponentRequest.filter field is null, so the whole Buckminster resolution is counted as a failure.

Definitely a bug.