Hi,
Ok. So if there are no objections then I’ll
refactor BPELCopyCommand to avoid changing command stack.
Thanks,
Oleg.
From:
bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx] On Behalf Of Michael Illiger2
Sent: Wednesday, April 02, 2008
7:32 PM
To: BPEL Designer project
developer discussions.
Subject: Re: [bpel-dev] question
about commands
Hi
I
just took a quick look at this. In my opinion BPELCopyCommand shouldn't extend
AutoUndoCommand because the underlying AutoUndoRecorder only records EMF
changes of Type ADD, REMOVE, SET, UNSET, MOVE, ADD_MANY, REMOVE_MANY. And
hopefully none of these changes occure when pressing Ctrl+C :-) I agree that
BPELCopyCommand shouldn't change the command stack and dirty the editor.
The
two fields undo and redo seem to be unused.
Cheers
Michael
|
|
Software
Developer - BPEL Editor / WID
|
|
WSS Business
Process Solutions Development 1
|
|
Dept. 4722, Bldg. 71032-01, Room 086
|
|
IBM Böblingen
Laboratory
|
|
Schönaicherstr.
220, D-71032 Böblingen
|
|
|
Notes:
|
Michael Illiger2/Germany/IBM
|
|
Internet:
|
milliger@xxxxxxxxxx
|
|
Phone:
|
++49-(0)7031-16-1273
|
|
Fax:
|
++49-(0)7031-16-4890
|
|
|
IBM Deutschland Entwicklung GmbH
|
|
Chairman of the
Supervisory Board: Martin Jetter
|
|
Board of
Management: Herbert Kircher (Chairman)
|
|
Corporate Seat:
Böblingen
|
|
Commercial
Register: Amtsgericht Stuttgart, HRB 243294
|
|
|
From:
|
"Danilov, Oleg V"
<oleg.v.danilov@xxxxxxxxx>
|
|
To:
|
"BPEL Designer project developer
discussions." <bpel-dev@xxxxxxxxxxx>
|
|
Date:
|
04/02/2008 09:54 AM
|
|
Subject:
|
[bpel-dev] question about commands
|
Hi,
I’m
wondering why BPELCopyCommand extends AutoUndoCommand, moreover, doExecute
method takes care about unfo/redo?
public void doExecute() {
TransferBuffer transferBuffer =
fBpelEditor.getTransferBuffer();
undo = transferBuffer.getContents();
transferBuffer.copyObjectsToTransferBuffer(fOriginalObjects,
fBpelEditor.getExtensionMap());
redo = transferBuffer.getContents();
}
From
my point of view the ‘copy’ command should not change undo stack.
Any objections?
Thanks,
Oleg.
--------------------------------------------------------------------
Closed Joint Stock Company Intel A/O
Registered legal address: Krylatsky
Hills Business
Park,
17 Krylatskaya Str., Bldg 4, Moscow
121614,
Russian
Federation
This e-mail and any attachments may contain
confidential material for
the sole use of the intended recipient(s). Any
review or distribution
by others is strictly prohibited. If you are not
the intended
recipient, please contact the sender and delete
all copies.
_______________________________________________
bpel-dev mailing list
bpel-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/bpel-dev
