[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [patch2 = patch1 + moving properties tab]] RE: [bpel-dev]separatingcore andview functionality inBPELEditor (was: RE: Our Dom FacadingKnowlegde)
|
https://bugs.eclipse.org/bugs/show_bug.cgi?id=191470
>-----Original Message-----
>From: Tishkov, Vitaly V
>Sent: Tuesday, June 05, 2007 9:28 PM
>To: 'BPEL Designer project developer discussions.'
>Cc: bpel-dev-bounces@xxxxxxxxxxx
>Subject: RE: [patch2 = patch1 + moving properties tab]] RE: [bpel-
>dev]separatingcore andview functionality inBPELEditor (was: RE: Our Dom
>FacadingKnowlegde)
>
>Hi Simon,
>
>I'll file a bug against Eclipse BPEL (main trunk) and propose a patch then.
>
>Thanks,
> Vitaly.
>
>>-----Original Message-----
>>From: bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx] On
>>Behalf Of Simon D Moser
>>Sent: Tuesday, June 05, 2007 9:24 PM
>>To: BPEL Designer project developer discussions.
>>Cc: BPEL Designer project developer discussions.; bpel-dev-bounces@xxxxxxxxxxx
>>Subject: Re: [patch2 = patch1 + moving properties tab]] RE: [bpel-
>>dev]separatingcore andview functionality inBPELEditor (was: RE: Our Dom
>>FacadingKnowlegde)
>>
>>Hi Vitaly,
>>
>>This is bogus code that shouldnt be in there ;-)
>>
>>It comes from the initial contribution of IBM, where there was a
>>distinction between a BPEL Spec compliant Editor and one that uses IBM
>>extensions. Thus - two Editor IDs ;-)
>>So in our case there is only ONE editor ID, and the method always return
>>that ID (IBPELUIConstants.BPEL_EDITOR_ID), and the constant
>>BPEL_SPEC_COMPLIANT_EDITOR_ID should go away.
>>I see that you did that in your patch already, so that is the right
>>solution!
>>
>>Cheers
>>Simon
>>
>>ps.: I applied the patch and am currently looking at it .. let you know
>>more soon
>>
>>Simon Moser, M.Eng.
>>
>>
>>
>> Websphere Integration Mail: IBM Deutschland Entwicklung
>> Developer Development smoser@xxxxxx. GmbH
>> Team Lead BPEL Editor com Vorsitzender des
>> Dept. 4722, Bldg. Phone: Aufsichtsrats: Martin Jetter
>> 71032-01, Room 086 +49-7031-16-43 Geschäftsführung: Herbert
>> Websphere Solutions and 04 Kircher
>> Services Fax: Sitz der Gesellschaft:
>> IBM Deutschland +49-7031-16-48 Böblingen
>> Entwicklung GmbH 90 Registergericht: Amtsgericht
>> Schönaicherstr. 220, D – Stuttgart, HRB 243294
>> 71032 Boeblingen
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> "Tishkov, Vitaly
>> V"
>> <vitaly.v.tishkov To
>> @intel.com> "BPEL Designer project developer
>> Sent by: discussions."
>> bpel-dev-bounces@ <bpel-dev@xxxxxxxxxxx>
>> eclipse.org cc
>> <bpel-dev-bounces@xxxxxxxxxxx>
>> Subject
>> 06/05/2007 07:06 [patch2 = patch1 + moving
>> PM properties tab]] RE: [bpel-dev]
>> separating core andview
>> functionality inBPELEditor (was:
>> Please respond to RE: Our Dom Facading Knowlegde)
>> "BPEL Designer
>> project developer
>> discussions."
>> <bpel-dev@eclipse
>> .org>
>>
>>
>>
>>
>>
>>
>>Hi there,
>>
>>The second patch contains the first one and also moves properties tab
>>related code from BPELEditor.java to BPELMultipageEditorPart.java.
>>
>>This patch also fixes the problem with the "Properties are not available"
>>message instead of contents at the properties tab.
>>
>>
>>I have a question about the following method in BPELEditor:
>>
>>protected String getPaletteAdditionsContributorId() {
>> if (contributorID == null) {
>> ProcessExtension extension = (ProcessExtension)
>>getExtensionMap().get(getProcess());
>> if (extension.isSpecCompliant()) {
>> contributorID =
>>IBPELUIConstants.BPEL_SPEC_COMPLIANT_EDITOR_ID;
>> } else {
>> contributorID =
>>getEditorSite().getId();
>> }
>> return contributorID;
>> }
>>}
>>
>>
>>Can anyone please explain me in a few words what
>>BPEL_SPEC_COMPLIANT_EDITOR_ID and BPEL_EDITOR_ID are?
>>
>>Thanks,
>> Vitaly.
>>
>>
>>
>>>-----Original Message-----
>>>From: bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx]
>>On
>>>Behalf Of Tishkov, Vitaly V
>>>Sent: Tuesday, June 05, 2007 4:46 PM
>>>To: BPEL Designer project developer discussions.
>>>Cc: bpel-dev-bounces@xxxxxxxxxxx
>>>Subject: [patch1 - moving Outline View] RE: [bpel-dev] separating core
>>andview
>>>functionality inBPELEditor (was: RE: Our Dom Facading Knowlegde)
>>>
>>>Hi Simon,
>>>
>>>Please find the first patch attached.
>>>Outline view related code is moved from BPELEditor.java to
>>>BPELMultipageEditorPart.java.
>>>
>>>Please let me know if it looks OK.
>>>
>>>Thanks,
>>> Vitaly.
>>>
>>>>-----Original Message-----
>>>>From: Tishkov, Vitaly V
>>>>Sent: Thursday, May 31, 2007 9:34 PM
>>>>To: 'BPEL Designer project developer discussions.'
>>>>Cc: bpel-dev-bounces@xxxxxxxxxxx
>>>>Subject: RE: [bpel-dev] separating core and view functionality
>>inBPELEditor
>>>>(was: RE: Our Dom Facading Knowlegde)
>>>>
>>>>Hi Simon,
>>>>
>>>>Yeah, I will :)
>>>>Thanks for revising the list and creating the branch.
>>>>
>>>>Thanks,
>>>> Vitaly.
>>>>
>>>>
>>>>
>>>>>-----Original Message-----
>>>>>From: bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx]
>>On
>>>>>Behalf Of Simon D Moser
>>>>>Sent: Thursday, May 31, 2007 6:06 PM
>>>>>To: BPEL Designer project developer discussions.
>>>>>Cc: bpel-dev-bounces@xxxxxxxxxxx
>>>>>Subject: Re: [bpel-dev] separating core and view functionality
>>inBPELEditor
>>>>>(was: RE: Our Dom Facading Knowlegde)
>>>>>
>>>>>Hey Vitaly,
>>>>>
>>>>>I browsed through the list also and I think this is a good start. Why
>>don't
>>>>>you go ahead and start creating a patch for this based on our new fancy
>>"
>>>>>MultiTab-DomFacade" branch ?
>>>>>
>>>>>Cheers
>>>>>Simon
>>>>>
>>>>>Simon Moser, M.Eng.
>>>>>
>>>>>
>>>>>
>>>>> Websphere Integration Mail: IBM Deutschland Entwicklung
>>>>> Developer Development smoser@xxxxxx. GmbH
>>>>> Team Lead BPEL Editor com Vorsitzender des
>>>>> Dept. 4722, Bldg. Phone: Aufsichtsrats: Martin
>>Jetter
>>>>> 71032-01, Room 086 +49-7031-16-43 Geschäftsführung: Herbert
>>>>> Websphere Solutions and 04 Kircher
>>>>> Services Fax: Sitz der Gesellschaft:
>>>>> IBM Deutschland +49-7031-16-48 Böblingen
>>>>> Entwicklung GmbH 90 Registergericht:
>>Amtsgericht
>>>>> Schönaicherstr. 220, D – Stuttgart, HRB 243294
>>>>> 71032 Boeblingen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> "Tishkov, Vitaly
>>>>> V"
>>>>> <vitaly.v.tishkov
>>To
>>>>> @intel.com> Simon D Moser/Germany/IBM@IBMDE,
>>>>> Sent by: "BPEL Designer project developer
>>>>> bpel-dev-bounces@ discussions."
>>>>> eclipse.org <bpel-dev@xxxxxxxxxxx>
>>>>>
>>cc
>>>>> Michael
>>Illiger2/Germany/IBM@IBMDE
>>>>> 05/30/2007 03:28
>>Subject
>>>>> PM [bpel-dev] separating core and
>>view
>>>>> functionality in BPELEditor
>>(was:
>>>>> RE: Our Dom Facading Knowlegde)
>>>>> Please respond to
>>>>> "BPEL Designer
>>>>> project developer
>>>>> discussions."
>>>>> <bpel-dev@eclipse
>>>>> .org>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>Hello,
>>>>>
>>>>>I tried to separate the "core" and "view" functionality of BPELEditor.
>>The
>>>>>"core" functionality is for model loading, "common" events handling
>>(like
>>>>>outline page selections, etc.), while "view" functionality is a set of
>>>>>fields/methods specific to displaying/editing graphical representation
>>of
>>>>>BPEL files.
>>>>>
>>>>>Please flick through the list below and let me know if there are big
>>>>>mistakes there. I'm sure that the list will have to be revised during
>>>>>refactoring itself but I need to understand if I'm generally correct
>>before
>>>>>starting any code changes. (Simon and I think that this will be done in
>>a
>>>>>separate branch though).
>>>>>
>>>>>"V" before a field/method name means that it's from "view" functionality
>>>>>and should stay in BPELEditor.
>>>>>"C" means that this is from core functionality and should be moved out
>>of
>>>>>BPELEditor. Most of it will appear in BPELMultiPageEditorPart (it's a
>>>>>sub-class of org.eclipse.ui.part.MultiPageEditorPart which is designed
>>for
>>>>>creating multi-tab editors; see
>>>>>http://dev.eclipse.org/mhonarc/lists/bpel-dev/msg00417.html for some
>>more
>>>>>details).
>>>>>
>>>>>Thanks,
>>>>> Vitaly.
>>>>>
>>>>>C org.eclipse.bpel.ui.BPELEditor.process
>>>>>C org.eclipse.bpel.ui.BPELEditor.editModelClient
>>>>>C org.eclipse.bpel.ui.BPELEditor.modelListenerAdapter
>>>>>С org.eclipse.bpel.ui.BPELEditor.editorAdapter
>>>>>V org.eclipse.bpel.ui.BPELEditor.transferBuffer
>>>>>C org.eclipse.bpel.ui.BPELEditor.extensionsResource
>>>>>C org.eclipse.bpel.ui.BPELEditor.extensionMap
>>>>>C org.eclipse.bpel.ui.BPELEditor.modelAutoUndoRecorder
>>>>>C org.eclipse.bpel.ui.BPELEditor.fileChangeListener
>>>>>C org.eclipse.bpel.ui.BPELEditor.outlinePage
>>>>>C org.eclipse.bpel.ui.BPELEditor.keyHandler
>>>>>C org.eclipse.bpel.ui.BPELEditor.selectionChangeListener
>>>>>C org.eclipse.bpel.ui.BPELEditor.traySelectionChangeListener
>>>>>V org.eclipse.bpel.ui.BPELEditor.lastSelectedEditPart
>>>>>V org.eclipse.bpel.ui.BPELEditor.adaptingSelectionProvider
>>>>>V org.eclipse.bpel.ui.BPELEditor.weakMultiViewerSelectionProvider
>>>>>V org.eclipse.bpel.ui.BPELEditor.filteredEditPartSelectionProvider
>>>>>V org.eclipse.bpel.ui.BPELEditor.dropTarget
>>>>>V org.eclipse.bpel.ui.BPELEditor.dropTargetListener
>>>>>V org.eclipse.bpel.ui.BPELEditor.postBuildRefactoringListener
>>>>>V org.eclipse.bpel.ui.BPELEditor.switchEntry
>>>>>V org.eclipse.bpel.ui.BPELEditor.flowEntry
>>>>>V org.eclipse.bpel.ui.BPELEditor.sequenceEntry
>>>>>V org.eclipse.bpel.ui.BPELEditor.controlCategory
>>>>>V org.eclipse.bpel.ui.BPELEditor.appendNewActions
>>>>>V org.eclipse.bpel.ui.BPELEditor.insertNewActions
>>>>>V org.eclipse.bpel.ui.BPELEditor.changeTypeActions
>>>>>C org.eclipse.bpel.ui.BPELEditor.currentPropertySheetPage
>>>>>? org.eclipse.bpel.ui.BPELEditor.contributorID
>>>>>C org.eclipse.bpel.ui.BPELEditor.commandFramework
>>>>>V org.eclipse.bpel.ui.BPELEditor.BPELEditor()
>>>>>V org.eclipse.bpel.ui.BPELEditor.BPELEditorAdapter
>>>>>V org.eclipse.bpel.ui.BPELEditor.getBPELEditor(ResourceSet)
>>>>>C org.eclipse.bpel.ui.BPELEditor.getEditModelClient()
>>>>>C org.eclipse.bpel.ui.BPELEditor.getResourceSet()
>>>>>C org.eclipse.bpel.ui.BPELEditor.getResource()
>>>>>C org.eclipse.bpel.ui.BPELEditor.getModelAutoUndoRecorder()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getTransferBuffer()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getAppendNewActions()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getInsertNewActions()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getChangeTypeActions()
>>>>>C org.eclipse.bpel.ui.BPELEditor.OutlinePage
>>>>>V org.eclipse.bpel.ui.BPELEditor.configureGraphicalViewer()
>>>>>V
>>org.eclipse.bpel.ui.BPELEditor.createBPELPaletteEntries(PaletteContainer)
>>>>>V
>>>>>org.eclipse.bpel.ui.BPELEditor.createTopControlPaletteEntries(PaletteRoot)
>>
>>>>>C org.eclipse.bpel.ui.BPELEditor.dispose()
>>>>>C org.eclipse.bpel.ui.BPELEditor.doRevertToSaved(IProgressMonitor)
>>>>>C org.eclipse.bpel.ui.BPELEditor.doSave(IProgressMonitor)
>>>>>C org.eclipse.bpel.ui.BPELEditor.isSaveAsAllowed()
>>>>>C org.eclipse.bpel.ui.BPELEditor.doSaveAs()
>>>>>C org.eclipse.bpel.ui.BPELEditor.performSaveAs()
>>>>>V org.eclipse.bpel.ui.BPELEditor.createPaletteRoot()
>>>>>C org.eclipse.bpel.ui.BPELEditor.gotoMarker(IMarker)
>>>>>C org.eclipse.bpel.ui.BPELEditor.gotoMarker(IMarker, EObject)
>>>>>C org.eclipse.bpel.ui.BPELEditor.showPropertiesView()
>>>>>C org.eclipse.bpel.ui.BPELEditor.isDirty()
>>>>>C org.eclipse.bpel.ui.BPELEditor.getExtensionMap()
>>>>>V org.eclipse.bpel.ui.BPELEditor.initializeGraphicalViewer()
>>>>>V org.eclipse.bpel.ui.BPELEditor.arrangeEditParts(GraphicalViewer)
>>>>>C org.eclipse.bpel.ui.BPELEditor.initializeFileChangeListener()
>>>>>C org.eclipse.bpel.ui.BPELEditor.commandStackChanged(EventObject)
>>>>>C org.eclipse.bpel.ui.BPELEditor.getKeyHandler()
>>>>>C org.eclipse.bpel.ui.BPELEditor.getEditorKeyHandler()
>>>>>C org.eclipse.bpel.ui.BPELEditor.getAdapter(Class)
>>>>>C org.eclipse.bpel.ui.BPELEditor.createBPELTabbedPropertySheetPage()
>>>>>C org.eclipse.bpel.ui.BPELEditor.replaceSelectionAction(ActionRegistry,
>>>>>IAction)
>>>>>C org.eclipse.bpel.ui.BPELEditor.createActions()
>>>>>V org.eclipse.bpel.ui.BPELEditor.createPaletteDependentActions()
>>>>>V org.eclipse.bpel.ui.BPELEditor.makeSelectionActionBPELOnlyEP(IAction)
>>>>>V org.eclipse.bpel.ui.BPELEditor.makeSelectionActionBPELOnly(IAction)
>>>>>C org.eclipse.bpel.ui.BPELEditor.getProcess()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getCommandStack()
>>>>>V org.eclipse.bpel.ui.BPELEditor.setAutoFlowLayout(boolean)
>>>>>V org.eclipse.bpel.ui.BPELEditor.getAutoFlowLayout()
>>>>>V
>>>>>org.eclipse.bpel.ui.BPELEditor.createBottomControlPaletteEntries(PaletteCon
>t
>>a
>>
>>>i
>>>>n
>>>>>er)
>>>>>
>>>>>V org.eclipse.bpel.ui.BPELEditor.createGraphicalViewer(Composite)
>>>>>V org.eclipse.bpel.ui.BPELEditor.hookGraphicalViewer()
>>>>>V org.eclipse.bpel.ui.BPELEditor.setGraphicalViewer(GraphicalViewer)
>>>>>V org.eclipse.bpel.ui.BPELEditor.createPaletteViewer(Composite)
>>>>>V org.eclipse.bpel.ui.BPELEditor.refreshGraphicalViewer()
>>>>>V org.eclipse.bpel.ui.BPELEditor.selectModelObject(Object)
>>>>>V org.eclipse.bpel.ui.BPELEditor.getSelection()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getAdaptingSelectionProvider()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getMultiViewerSelectionProvider()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getFilteredEditPartSelectionProvider()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getGraphicalViewer()
>>>>>V org.eclipse.bpel.ui.BPELEditor.refreshHoverHelp(EObject)
>>>>>V org.eclipse.bpel.ui.BPELEditor.initializeRefactoringListeners()
>>>>>V org.eclipse.bpel.ui.BPELEditor.createPartControl(Composite)
>>>>>C org.eclipse.bpel.ui.BPELEditor.getFileInput()
>>>>>C org.eclipse.bpel.ui.BPELEditor.init(IEditorSite, IEditorInput)
>>>>>C org.eclipse.bpel.ui.BPELEditor.loadModel()
>>>>>C org.eclipse.bpel.ui.BPELEditor.loadModelWithoutEditModel()
>>>>>C org.eclipse.bpel.ui.BPELEditor.getCommandFramework()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getActionRegistry()
>>>>>V org.eclipse.bpel.ui.BPELEditor.initializeTrayViewer()
>>>>>V org.eclipse.bpel.ui.BPELEditor.registerViewer(EditPartViewer)
>>>>>C org.eclipse.bpel.ui.BPELEditor.modelDeleted(ResourceInfo)
>>>>>C org.eclipse.bpel.ui.BPELEditor.modelDirtyStateChanged(ResourceInfo)
>>>>>C org.eclipse.bpel.ui.BPELEditor.modelLocationChanged(ResourceInfo,
>>IFile)
>>>>>C org.eclipse.bpel.ui.BPELEditor.modelReloaded(ResourceInfo)
>>>>>C org.eclipse.bpel.ui.BPELEditor.updateInputFile(IPath)
>>>>>C org.eclipse.bpel.ui.BPELEditor.updateTitle()
>>>>>C org.eclipse.bpel.ui.BPELEditor.removeUnusedExtensions()
>>>>>C org.eclipse.bpel.ui.BPELEditor.getArtifactsDefinition()
>>>>>V org.eclipse.bpel.ui.BPELEditor.getPaletteAdditionsContributorId()
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>-----Original Message-----
>>>>>>From: Simon D Moser [mailto:SMOSER@xxxxxxxxxx]
>>>>>>Sent: Wednesday, May 30, 2007 3:51 PM
>>>>>>To: BPEL Designer project developer discussions.
>>>>>>Cc: Tishkov, Vitaly V; Michael Illiger2
>>>>>>Subject: RE: Our Dom Facading Knowlegde
>>>>>>
>>>>>>Hi Vitaly,
>>>>>>
>>>>>>first I moved the discussion to the list - not even sure why this was
>>>>>>started in private ;-)
>>>>>>
>>>>>>>OK, let's start from there.
>>>>>>
>>>>>>>In the future I see the following 3 easy steps of 'binding' source
>>view
>>>>>>(structuredTextEditor) and the DOM model:
>>>>>>> 1) create DOM model;
>>>>>>> 2) initialize the source view;
>>>>>>> 3) set the source view model to the DOM model created
>>above.
>>>>>>>At the moment StructuredTextEditor doesn't allow changing it's model
>>(the
>>>>>>only method that changes the value of the fStructuredModel field is
>>>>>>>deprecated private setModel(). So, we'll probably have to extend
>>>>>>StructuredTextEditor for our needs.
>>>>>>
>>>>>>I am OK with the approach. However, the thing is that we probably must
>>use
>>>>>>StructuredSourceEditor or StructuredXMLEditor or something.
>>>>>>
>>>>>>> Yes, your assumption is correct. Sorry for being not clear.
>>>>>>> I'll send my proposal for separating "core" and "view" in another
>>>>>message
>>>>>>
>>>>>>Ok, cool. I'm waiting for that one then.
>>>>>>
>>>>>>>OK, I see.
>>>>>>>It seems to me that we'll need a branch for our work, am I correct?
>>>>>>
>>>>>>Generally yes. I would think that a branch is the better solution here.
>>>>>Let
>>>>>>me find out how to create one (we can apply the source tab patch on the
>>>>>>branch right away).
>>>>>>Michal, do you know how this works by any chance?
>>>>>
>>>>>-- cut --
>>>>>_______________________________________________
>>>>>bpel-dev mailing list
>>>>>bpel-dev@xxxxxxxxxxx
>>>>>https://dev.eclipse.org/mailman/listinfo/bpel-dev
>>(See attached file: patch2-moving-outline-view-and-properties-tab.txt)
>>_______________________________________________
>>bpel-dev mailing list
>>bpel-dev@xxxxxxxxxxx
>>https://dev.eclipse.org/mailman/listinfo/bpel-dev
