Bug 98883 - [Perspectives] [RCP] Standalone notitle views position toolbar incorrectly
Summary: [Perspectives] [RCP] Standalone notitle views position toolbar incorrectly
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P5 normal with 14 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
: 239359 328009 337502 (view as bug list)
Depends on:
Blocks: 242872
  Show dependency tree
 
Reported: 2005-06-08 03:35 EDT by Stefan Xenos CLA
Modified: 2020-01-07 16:59 EST (History)
16 users (show)

See Also:


Attachments
Screenshot of the bogus toolbars (41.15 KB, image/png)
2005-06-08 03:36 EDT, Stefan Xenos CLA
no flags Details
toolbar after setting showTitle=true (7.79 KB, image/png)
2006-02-16 23:58 EST, Paul Morganthall CLA
no flags Details
image of toolbar in standalone project explorer (3.18 KB, image/png)
2008-07-14 11:54 EDT, Andrew Eidsness CLA
no flags Details
Screenshot depicting the problem in question. (24.48 KB, image/gif)
2010-09-30 10:28 EDT, Remy Suen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2005-06-08 03:35:47 EDT
N20050606-0010

Load the org.eclipse.ui.tests plugin and open the UI Test Standalone View
Perspective 2. Notice that several of the views have a toolbar

The toolbar is supposed to be hidden for standalone views with no title.
Comment 1 Stefan Xenos CLA 2005-06-08 03:36:40 EDT
Created attachment 22589 [details]
Screenshot of the bogus toolbars
Comment 2 Nick Edgar CLA 2005-06-08 09:57:25 EDT
If the view has toolbar contributions, they should be shown, just as with
regular views.  What was the behaviour in 3.0?
Comment 3 Stefan Xenos CLA 2005-06-08 15:04:54 EDT
Although this may just be a miscommunication, I recall this being the intended
behavior in the original design discussions. I'm starting to feel like the
intended behavior for notitle views has become a moving target. Could we please
spell it out somewhere?
Comment 4 Nick Edgar CLA 2005-06-08 17:27:12 EDT
Really, I'm not making this up.  showTitle=false just means no titlebar, and no
system buttons for close etc.  If there are ISV toolbar or menu contributions,
they should be shown.  The intent is to expose the full view functionality,
except for the titlebar.
Comment 5 Nick Edgar CLA 2005-06-08 17:28:28 EDT
I don't think the toolbar or view menu were ever a concern for the original
driving use case (the preview pane in LWP).  Matt?
Comment 6 Stefan Xenos CLA 2005-06-08 18:12:01 EDT
In that case, where are they supposed to go and what should they look like?
Comment 7 Nick Edgar CLA 2005-06-08 18:42:10 EDT
I'd vote for something as close to the regular layout as possible
E.g. in the default presentation, toolbar at top, right aligned, with view menu
to the right of that, like it would flow if they were forced to wrap for a
regular view.
Comment 8 Matthew Hatem CLA 2005-06-09 10:40:17 EDT
Re comment #5, yes this is expected behavior and not an issue for the LWP use case.

I agree with Nick's suggestiong in comment #7.
Comment 9 Nick Edgar CLA 2005-06-09 11:05:24 EDT
I'd like to consider this one for RC3.
Comment 10 Michael Van Meekeren CLA 2005-06-14 16:09:00 EDT
there do not seem to be any users of this (Stand-alone + toolbar), deferring to 3.2
Comment 11 Franz Poppenborg CLA 2005-09-28 10:48:04 EDT
I just want to say that i'm trying to use this feature until i found this bug
report, so please don't defer it any longer
Comment 12 Nick Edgar CLA 2005-10-05 13:29:02 EDT
Changing title to reflect the actual problem.  Toolbars are shown (correctly)
but are not positioned correctly.
Comment 13 Paul Morganthall CLA 2006-02-16 23:55:49 EST
The doc (and comments here) seem to say that toolbar and menu contributions will always be shown.  Using Build id: N20060212-0010 on Mac OS X 10.4.4, I don't see view menus and toolbars with addStandaloneView() unless I set showTitle=true.

I could not find the UI Test Standalone View Perspective 2 (looks like it was deleted?), so I tried a basic test.  Create a new plug-in project using the template "RCP application with a view".  It starts with no menus or toolbars, and uses addStandaloneView(showTitle=false).

At the bottom of View.createPartControl(), I added an Action:
   getViewSite().getActionBars().getToolBarManager().add(new Action() {
      public void run() {
         System.out.println("action activated.");
      }
   }) ;

No toolbar shows up.  Then I changed showTitle to true -- and the action shows up on the toolbar, along with what looks like a title bar (see attachment).  Given the documentation for IPageLayout and the comments here, I expected the toolbar to always be there, whether showTitle was true or false.
Comment 14 Paul Morganthall CLA 2006-02-16 23:58:55 EST
Created attachment 34896 [details]
toolbar after setting showTitle=true
Comment 15 Paul Webster CLA 2006-09-28 15:15:03 EDT
Is this still a problem in 3.3?

PW
Comment 16 Paul Morganthall CLA 2006-09-28 18:05:18 EDT
I performed the test described in comment 13 using 3.3 M2 (I20060922-0010) on Mac OS X 10.4.7 and Java 1.5.0.  The behavior was the same as that described in comment 13.  The action does not appear unless showTitle is set to true.
Comment 17 Paul Webster CLA 2006-09-28 21:00:50 EDT
problem exist
PW
Comment 18 Jeff Care CLA 2007-10-30 13:01:37 EDT
I can confirm that the problem still exists as of Eclipse 3.4 M2
Comment 19 Eric Moffatt CLA 2007-10-30 14:22:30 EDT
Boris and I both agree that if a view has declared menu and/or toolbar items that they should be available regardless of the state of the 'showTitle' flag.

What this would amount to is to use the same layout we get when the title (tab) area is too small to contain the TB and menu chevron (i.e. they show up to the right of the 'message' if there's enough space and below it otherwise.

Paul, can you confirm that this type of view still -uses- a CTabFolder?
Comment 20 Andrew Eidsness CLA 2008-07-14 11:54:34 EDT
Created attachment 107339 [details]
image of toolbar in standalone project explorer

I just wanted to confirm that this is still a problem.  The attached screenshot shows the toolbar rendered on top of the view's content.  In this case I'm running eclipse 3.4 and the view is the Common Navigator's project explorer ("org.eclipse.ui.navigator.ProjectExplorer").

Are there plans to fix this?  In my use case the ideal solution would be to add a #showToolbar (the same as #showTitlebar) that would let me turn off the view's toolbar.  However, I understand that is unlikely to be the accepted solution.

The minimum solution for me is to at least render the toolbar in the proper location.  If no one is planning to work on this then I could try to find time to look into it.
Comment 21 Paul Webster CLA 2008-08-14 10:06:47 EDT
*** Bug 239359 has been marked as a duplicate of this bug. ***
Comment 22 Bjoern Sundin CLA 2008-10-06 08:18:03 EDT
I can confirm this bug exist in 3.4.0 Build id: I20080617-2000
Comment 23 Ben Fox-Moore CLA 2009-07-02 04:51:49 EDT
This problem still exists in 3.5
Comment 24 Remy Suen CLA 2010-09-30 10:28:37 EDT
Created attachment 179960 [details]
Screenshot depicting the problem in question.

My 'Progress' view's toolbar ends up being way over in the top left hand side by the 'Package Explorer'.

<extension
    point="org.eclipse.ui.perspectiveExtensions">
  <perspectiveExtension
      targetID="org.eclipse.jdt.ui.JavaPerspective">
    <view standalone="true"
        showTitle="false"
        id="org.eclipse.ui.views.ProgressView"
        ratio="0.5"
        relationship="right"
        relative="org.eclipse.ui.views.ProblemView">
    </view>
  </perspectiveExtension>
</extension>
Comment 25 Remy Suen CLA 2010-10-18 08:54:21 EDT
*** Bug 328009 has been marked as a duplicate of this bug. ***
Comment 26 Miles Parker CLA 2011-02-17 19:40:00 EST
*** Bug 337502 has been marked as a duplicate of this bug. ***
Comment 27 Eclipse Genie CLA 2020-01-07 16:59:07 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.