Bug 98130 - [Preferences] dialog should remember its size
Summary: [Preferences] dialog should remember its size
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
: 493216 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-02 11:32 EDT by Bryan Hunt CLA
Modified: 2020-07-19 12:25 EDT (History)
5 users (show)

See Also:


Attachments
Too small (55.40 KB, image/png)
2020-07-18 12:29 EDT, John Hendrikx CLA
no flags Details
Right pane too small (did not resize it myself) (75.21 KB, image/png)
2020-07-19 12:25 EDT, John Hendrikx CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Hunt CLA 2005-06-02 11:32:55 EDT
It would be nice if the preference dialog would remember its last resize.
Comment 1 Kim Horne CLA 2005-06-02 12:41:13 EDT
The preference dialog should already be doing this...
Comment 2 Tod Creasey CLA 2005-06-02 12:51:58 EDT
No it doesn't and should not. We let the page computeSize and if that page wants
to do something special we should not break it. Pages may also look different
between invocations (due to changed content etc.) so we need to let them decide
what to do.
Comment 3 Bryan Hunt CLA 2005-06-02 14:40:01 EDT
This is rather inconvenient for the user.  I often make the dialog larger, then drag the sash to the right so I 
can see expanded sections which makes navigation much easier.
Comment 4 Tod Creasey CLA 2005-06-02 14:51:08 EDT
See Bug 94966 for the discussion of the tree. The problem with caching the size
is that it is very annoying for users who don't want to keep a resized dialog 
Comment 5 Dani Megert CLA 2016-05-11 08:59:55 EDT
*** Bug 493216 has been marked as a duplicate of this bug. ***
Comment 6 Björn Michael CLA 2016-05-11 09:45:32 EDT
(In reply to Bryan Hunt from comment #3)
> This is rather inconvenient for the user.  I often make the dialog larger,
> then drag the sash to the right so I 
> can see expanded sections which makes navigation much easier.

It is in deed markedly inconvenient and annoying that I have to resize the preference dialog again and again and again because the available space on monitor isn't used for presenting content. Instead the content is sqeezed in a little window and have to be resized. I can't believe that the current behavoir is favoured.
Comment 7 Lars Vogel CLA 2020-02-05 08:28:04 EST
Most of our dialogs remembers their size. So should the preference dialog.
Comment 8 Lars Vogel CLA 2020-02-05 08:29:38 EST
Julian, WDYT? If you agree, can you take this bug?
Comment 9 Julian Honnen CLA 2020-02-05 08:56:57 EST
Currently the tree remembers its width and the dialog size is determined by the page.

I'm fine with this behavior and don't feel the need to constantly resize the dialog. Memorizing a fixed size would certainly be wrong given the diverse page contents.
Comment 10 Lars Vogel CLA 2020-02-05 09:33:06 EST
Moving back to won't fix.
Comment 11 Lars Vogel CLA 2020-02-05 09:33:21 EST
Thanks, Julian.
Comment 12 John Hendrikx CLA 2020-07-18 12:29:35 EDT
Created attachment 283637 [details]
Too small

I cannot believe that this is the "official" position on this bug, so I'm attaching a screenshot to show how the window opens up on my system, as I cannot believe this is the intention.

1) There are double scrollbars in the preference page tree because not everything fits
2) Not even the "Type filter text" fits
3) The window takes up about 30% height and 25% width on my 4K screen...

Yes, it resizes based on preference page.  No, it doesn't resize the page tree area without manual intervention.

So ***every time*** I need to open this window I need to drag the page tree slider to right to get rid of the horizontal scrollbar, and increase the height of the window to get rid of the vertical scroll bar.

Why not simply remember the size, but resize it if a page needs more space?  It *already* does this, apart from the remembering the size part...
Comment 13 Gao Hao CLA 2020-07-18 13:17:34 EDT
(In reply to John Hendrikx from comment #12)
> Created attachment 283637 [details]
> Too small
> 
> I cannot believe that this is the "official" position on this bug, so I'm
> attaching a screenshot to show how the window opens up on my system, as I
> cannot believe this is the intention.
> 
> 1) There are double scrollbars in the preference page tree because not
> everything fits
> 2) Not even the "Type filter text" fits
> 3) The window takes up about 30% height and 25% width on my 4K screen...
> 
> Yes, it resizes based on preference page.  No, it doesn't resize the page
> tree area without manual intervention.
> 
> So ***every time*** I need to open this window I need to drag the page tree
> slider to right to get rid of the horizontal scrollbar, and increase the
> height of the window to get rid of the vertical scroll bar.
> 
> Why not simply remember the size, but resize it if a page needs more space? 
> It *already* does this, apart from the remembering the size part...

Hello, which dialog font do you use? I think it is nice.

Furthermore, the left tree should have a responsive width, when we expand a deep node, the width of tree should be larger.
Comment 14 John Hendrikx CLA 2020-07-19 12:25:03 EDT
Created attachment 283642 [details]
Right pane too small (did not resize it myself)

The font I use is Segoe UI Semibold 11 (on a 4k screen at 150%).  You can get similar results with Noto Sans Semibold 11.

I suspect the 150% screen size might be part of the reason why the panes are not resizing properly.

There is definitely some wierd things going on.  For example, the size of the dialog depends on which page was last selected when you re-open the dialog.  Then when you select other pages, the dialog might get resized bigger... but not always.  See the second attachment that shows scrollbars for the "Java > Compiler" page.

If you close the dialog (while on the Compiler page) and reopen it, it will resize properly.  If you then select the General page, close it, and reopen it, the dialog will be much smaller again.

I'd be quite happy with a solution where the dialog can only ever get bigger.

The left tree for me has never shown any responsiveness, it's always too small when Eclipse was restarted.  It does remember its size most of the time.  It never changes size when I select a deep node.