Bug 97667 - [Preferences][PatchProvided] Pref Page General/Editors - problems
Summary: [Preferences][PatchProvided] Pref Page General/Editors - problems
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 95565
Blocks:
  Show dependency tree
 
Reported: 2005-05-31 15:06 EDT by Sebastian Davids CLA
Modified: 2007-08-07 11:26 EDT (History)
1 user (show)

See Also:

Attachments
pic showing the problems (44.43 KB, image/png)
2005-05-31 15:08 EDT, Sebastian Davids CLA 		no flags Details
fix (8.83 KB, patch)
2007-06-14 09:09 EDT, Sebastian Davids CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Davids CLA 2005-05-31 15:06:48 EDT 
The three links "See ..." at the top do not use the dialog font.

Suggest changing the mnemonic of "Number of opened editors before closing" from
'g' to 'n' -- depending on the font used 'g' is a suboptimal letter for
mnemonics (see screenshot with Trebuchet MS.

Alignment problems see screenshot.
Comment 1 Sebastian Davids CLA 2005-05-31 15:08:48 EDT 
Created attachment 22088 [details]
pic showing the problems
Comment 2 Sebastian Davids CLA 2005-05-31 15:51:57 EDT 
Clicking on "Restore Defaults" does not reset the value of the "Other" combo.
Comment 3 Tod Creasey CLA 2007-06-13 15:46:39 EDT 
There are currently no plans to work on this however I would be happy to look over a contribution
Comment 4 Sebastian Davids CLA 2007-06-14 09:09:01 EDT 
Created attachment 71303 [details]
fix

- removed explicit font-setting w/ dialogApplyFont
- removed unnecessary lines
- added some layout code
- changed old-style GridData-ctor calls to new-style ctor-calls
- mnemonic on n instead of g
- copyright update

After applying the patch you might also want to reformat the source due to its inconsistent indention.
Comment 5 Sebastian Davids CLA 2007-06-14 09:09:34 EDT 
reopen due to patch
Comment 6 Tod Creasey CLA 2007-06-27 09:43:04 EDT 
Patch released for build >20070627
Comment 7 Tod Creasey CLA 2007-08-07 11:26:30 EDT 
Verified in  I20070807-0010