Bug 97649 - [Preferences] [Themes] Colors and Fonts preference page shows with no buttons
Summary: [Preferences] [Themes] Colors and Fonts preference page shows with no buttons
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 112690 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-05-31 14:41 EDT by Douglas Pollock CLA
Modified: 2008-04-30 10:44 EDT (History)
3 users (show)

See Also:

Attachments
Fix (8.47 KB, patch)
2008-01-30 12:07 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Pollock CLA 2005-05-31 14:41:51 EDT 
3.1 RC1, Windows XP Professional SP1

It is possible to get the Colors and Fonts preference page to show with no "Use
System Font", "Change...", and "Reset" buttons.  Selects the Colors and Fonts
preference page, and select a font entry.  Change the font and click okay.  Open
the preference dialog again.  Focus is the typeahead filter (top-left), but the
font that had previously been changed is selected in the tree.  However, no
buttons appear.  If I click on a font in the tree, and then click in the
typeahead, there are still buttons.

If the preference page is open when the preference dialog is first created, the
buttons should be created appropriate for the remembered selection.
Comment 1 Markus Keller CLA 2006-03-21 13:23:51 EST 
Simple steps to reproduce in I20060321-1210:
Open preferences, type "font", press Return key.
Comment 2 Kim Horne CLA 2007-06-27 13:57:37 EDT 
*** Bug 112690 has been marked as a duplicate of this bug. ***
Comment 3 Dani Megert CLA 2007-09-25 12:28:32 EDT 
Not minor as missing buttons can be quite disturbing.
Comment 4 Markus Keller CLA 2008-01-30 12:07:08 EST 
Created attachment 88307 [details]
Fix

I hate this bug. Here's a simple fix.
Comment 5 Dani Megert CLA 2008-01-31 04:50:54 EST 
Thanks for the patch Markus. I'll review and commit if OK.
Comment 6 Dani Megert CLA 2008-01-31 05:19:15 EST 
Committed with the patch but replaced compact assignment.

In a second commit I cleaned up the patch and code a bit:
- renamed the new method to update... instead of handle...
- moved the call to the new method from hookListeners to createContents
- removed all empty Javadoc stubs that generated Javadoc warnings
- fixed some typos. Also as this better fits the current scheme in this class.

Available in builds > N20080131-0010.
Comment 7 Dani Megert CLA 2008-04-30 10:44:27 EDT 
Verified in I20080430-0100.