Bug 97626 - Help shows highlighted words as blank
Summary: Help shows highlighted words as blank
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.1   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P1 normal (vote)
Target Milestone: 3.1 RC2   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-31 14:09 EDT by Nick Edgar CLA
Modified: 2005-06-03 19:29 EDT (History)
3 users (show)

See Also:


Attachments
Screen shot (TIFF format) (82.22 KB, image/tiff)
2005-05-31 14:10 EDT, Nick Edgar CLA
no flags Details
screen shot PDF (90.54 KB, application/pdf)
2005-06-01 10:56 EDT, Konrad Kolosowski CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-05-31 14:09:47 EDT
3.1 RC1

- Window > Preferences > General > Content Types
- press the Help key
- in the resulting help window, click on "Content Types"
- the page has blank areas where "Content Types" is supposed to be highlighted
Comment 1 Nick Edgar CLA 2005-05-31 14:10:31 EDT
Created attachment 22082 [details]
Screen shot (TIFF format)
Comment 2 Nick Edgar CLA 2005-05-31 14:13:14 EDT
There's also a large blank area at top.
Comment 3 Konrad Kolosowski CLA 2005-05-31 15:31:27 EDT
What's your Safari version?
Comment 4 Nick Edgar CLA 2005-05-31 15:35:55 EDT
Safari 1.3 on OS X 10.3.9.
Comment 5 Konrad Kolosowski CLA 2005-05-31 20:32:27 EDT
Thanks.  I am running Safari 1.3 (v312) and cannot reproduce the problem.
It used to be an issue in the past.  See bug 47298.
Comment 6 Konrad Kolosowski CLA 2005-06-01 10:55:10 EDT
I reproduced in the help view, and now realize your screen shot is showing the view not the browser.
Comment 7 Konrad Kolosowski CLA 2005-06-01 10:56:54 EDT
Created attachment 22154 [details]
screen shot PDF

I attach an image of the the same document displayed in the help view, and in
the browser (after clicking "show in external window"
Comment 8 Dejan Glozic CLA 2005-06-01 11:06:20 EDT
The help view uses the embedded browser. Check the narrow_book.css to see if 
there are some CSS styles that may cause this on Mac.
Comment 9 Nick Edgar CLA 2005-06-01 14:15:33 EDT
My Safari is v312 too.
Comment 10 Nick Edgar CLA 2005-06-01 14:16:30 EDT
Note that the screenshot is of the sidecar help window used for dialogs, which I guess uses the same 
code as the help view.
Comment 11 Konrad Kolosowski CLA 2005-06-01 14:37:39 EDT
Highlighting:
It turns out that user agent in embedded browser is different than in stand alone Safari.  The string is 
missing "Safari" and its version at the end.  Chris is this intentional?
Since the fix for bug 47298 was looking for "Safari" it was not working in the embedded.  For RC2, I 
have added a check for "AppleWebKit" to javascript that does highlighting.  It fixes the words 
highlighting problem.

Dejan,
The title is still white on white because narrow_book.css if using "Highlight" system color that Safari 
does not understand.

Comment 12 Dejan Glozic CLA 2005-06-01 14:43:47 EDT
Can we have ws-specific entries in CSS?
Comment 13 Christophe Cornu CLA 2005-06-03 09:08:49 EDT
> is this intentional?
No. Probably a side effect of using Webkit. CC'ing Grant. I believe there is 
API to set the user agent property in Webkit.
Comment 14 Dejan Glozic CLA 2005-06-03 19:29:00 EDT
I Googled for the way to detect Safari in CSS but did not find anything that 
was not kludgy. 

Instead, I added another line in the CSS injection filter that imports 
<os>_narrow_book.css script when topics are shown in the help view. If 
present, this CSS can be used to override some settings that are misbehaving 
on a particular os.

I added macosx_narrow_book.css - a small file that sets H1 and H2 back to 
black. Works like charm.

This can also be used to tweak topic presentation in the view for IE (for 
windows) and Mozilla (Linux). OS is good enough because we only use one 
browser per OS for the Browser widget.