Bug 97608 - Workspace save fails if marker contains > 65,536 byte message
Summary: Workspace save fails if marker contains > 65,536 byte message
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P2 critical (vote)
Target Milestone: 3.1 RC2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-31 13:36 EDT by John Arthorne CLA
Modified: 2005-06-06 13:02 EDT (History)
1 user (show)

See Also:

Attachments
Log file with complete trace (39.31 KB, text/plain)
2005-05-31 13:36 EDT, John Arthorne CLA 		no flags Details
Log file (7.36 KB, text/plain)
2005-05-31 13:44 EDT, John Arthorne CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2005-05-31 13:36:11 EDT 
Build: 3.1 RC1

If you create a marker with a String property containing more than 65,536 bytes,
it causes workspace save to fail.  The workspace can be restored in the next
session, but some information (such as remaining markers and sync info) is lost.
 See bug 97440 for details.
Comment 1 John Arthorne CLA 2005-05-31 13:36:44 EDT 
Created attachment 22075 [details]
Log file with complete trace

This log contains stacks for the save failure, and the subsequent startup
failure.
Comment 2 John Arthorne CLA 2005-05-31 13:38:16 EDT 
Should consider doing something for 3.1 RC2. We should catch the
UTFDataFormatException, log it, and then replace the marker property with an
error message.  This shouldn't cause the remainder of the workspace save to fail.
Comment 3 John Arthorne CLA 2005-05-31 13:44:25 EDT 
Created attachment 22077 [details]
Log file

I attached the wrong log file. Here is the correct one.
Comment 4 John Arthorne CLA 2005-06-02 12:06:23 EDT 
Changing severity to critical because this bug causes loss of data (although
admittedly not a common case).  DJ, I'd like to consider a targetted fix for RC2
(log the failure and continue with the save).
Comment 5 DJ Houghton CLA 2005-06-03 07:27:40 EDT 
+1
Comment 6 John Arthorne CLA 2005-06-06 13:02:43 EDT 
Fix released and regression test added (Bug_97608.java).