Bug 97121 - It takes forever to open folder with large xml file
Summary: It takes forever to open folder with large xml file
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 major (vote)
Target Milestone: 3.1 RC2   Edit
Assignee: Kevin Barnes CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-05-28 15:58 EDT by Mikhail Moussikhine CLA
Modified: 2005-06-30 22:11 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Moussikhine CLA 2005-05-28 15:58:15 EDT 
Put any large XML file (> 50MB) in a folder and try to open folder in "Package
Explorer". Version 3.0 opened it instantly, but 3.1 takes several minutes and
interface is dead. If one is patient enough to wait for it, all next attempts
are instant.
Comment 1 Rafael Chaves CLA 2005-05-29 16:02:59 EDT 
What build are you using? Do you have only Eclipse SDK plug-ins or you have
3rd-party plug-ins installed?
Comment 2 Mikhail Moussikhine CLA 2005-05-29 17:59:00 EDT 
Version: 3.1.0
Build id: I20050527-1300

No third-party plugins. Clean fresh install. I tried it with 3.1M7 and now with
3.1RC1. Result is the same.
Comment 3 Rafael Chaves CLA 2005-05-29 23:39:04 EDT 
Will take a look.
Comment 4 Rafael Chaves CLA 2005-05-30 11:17:20 EDT 
testing notification
Comment 5 Rafael Chaves CLA 2005-05-30 11:37:28 EDT 
It is actually a problem with the Ant build script content describer.

org.eclipse.ant.internal.core.contentDescriber.AntHandler#startElement() should
always abort with an StopParsingException, since if we are only interested in
the root element.

Right now, for every non-Ant XML file, the Ant build script describer will parse
the entire file.

Raising severity.
Comment 6 Rafael Chaves CLA 2005-05-30 11:41:29 EDT 
Forgot to reassign...
Comment 7 Darin Swanson CLA 2005-05-31 00:08:57 EDT 
Investigate for RC2
Comment 8 Darin Swanson CLA 2005-06-02 17:42:25 EDT 
The AntBuildFileContentDescriber is interested in more than the root element. 
It is also looking for target elements to attempt to distinguish Ant buildfile 
from other XML files that have top level project elements.
But...we can fail fast if the top level element is not a project.
Comment 9 Darin Swanson CLA 2005-06-02 17:56:21 EDT 
Fixed in AntHandler
Comment 10 Darin Swanson CLA 2005-06-02 17:56:39 EDT 
Please verify Kevin.
Comment 11 Kevin Barnes CLA 2005-06-06 14:01:35 EDT 
verified