Bug 96997 - Sensor attributre fileFooterSize should have a default value of zero
Summary: Sensor attributre fileFooterSize should have a default value of zero
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP.monitoring (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Alex Nan CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, Documentation
Depends on:
Blocks:
 
Reported: 2005-05-27 10:59 EDT by Dave Smith CLA
Modified: 2010-06-03 15:10 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Smith CLA 2005-05-27 10:59:31 EDT 
Currently, if the GLA Sensor attribute fileFooterSize is not specified in the 
adapter file it is given a default value of 90.  fileFooterSize>0 should only 
be specified if the log file indeed has a footer section that is not parsed and 
is not used to determine if the file has been appended.  Since not many log 
files contain footer sections, the default value of fileFooterSize should be 
zero and then it only needs to be specified in adapter files for logs that 
contain a footer.  Most current adapter files don't specify the filtFooterSize 
and therefore get a default value of 90 which may cause problems when 
continuously monitoring those log files that do not contain a footer.

This change will affect those adapter files for log files that do have a footer 
and don't specify the fileFooterSize in the Sensor attributes and assume that 
the default value of 90 will be used.
Comment 1 Dave Smith CLA 2005-05-27 11:02:40 EDT 
This change will require a change in the documentation.  Documentation is 
frozen for TPTP 4.0 so this change cannot be made until 4.1.
Comment 2 Dave Smith CLA 2005-07-21 15:41:17 EDT 
Deferring this until a breaking API release because this change may break 
existing adapters that assume the default footer size is 90.
Comment 3 Eric Labadie CLA 2007-09-12 14:59:25 EDT 
This is required from the AC perspective.
Comment 4 Dave Smith CLA 2007-09-13 18:49:13 EDT 
This bugzilla only affects adapters used in live log monitoring scenarios because fileFooterSize is only used when the context is configured with continuousOperation="true". In log import scenarios fileFooterSize is not used.
Comment 5 Dave Smith CLA 2007-09-14 12:10:46 EDT 
The documentation file that needs to be updated for this change is:

org.eclipse.tptp.monitoring.doc.isv/tasks/tconfiguresensor_rules.html

I am adding a sizing of the work required:

1 hr - Updating the code and documentation
3 hrs - testing the existing TPTP adapters running in continuous live monitoring mode to ensure this change does not cause any regressions.
4 hrs total.

As indicated in Comment #2 this change cannot be done until a breaking API release because it may cause existing adapters for logs that have a footer to no longer work properly in live monitoring mode.
Comment 6 Alex Nan CLA 2007-12-17 10:17:47 EST 
Reassigning defects to current component owner.
Comment 7 Alex Nan CLA 2008-06-24 17:58:01 EDT 
No support for the GLA will be provided post 4.5.
Comment 8 Alex Nan CLA 2008-06-24 18:00:47 EDT 
Closing.