Community
Participate
Working Groups
Currently the background color of the message dialog changes to a lighter gray when a message or error is displayed. We should use the background color from the hover background (SWT.COLOR_INFO_BACKGROUND). But do do so we have to change the layout of the dialogs since our current alignment is bad had with a yellow background it looks stupid.
should discuss with workbench whether to use hover color for error messages.
Nick, can you please comment on that idea. We noticed that some MS applications are using the hover background color if the show errors. May be that has something to do with screen readers.
I doubt the colour affects screen readers. They normally ignore colour (although they can read the current colour on demand). Do you have some examples in MS apps of using this colour for error messages?
An example is Outlook Express. Mark a message as watched or ignored and open the message by double clicking on it.
Hmm. It does look nicer, doesn't it.
Nick, do you plan to do something with the background color for error messages in the workbench ? If not I will postpone this PR > 2.0.
I would like to remove the hardcoded colour in our copy of MessageLine, and could change it to this, however we should be consistent with other wizards and dialogs. What are the layout problems mentioned in the main description above?
As far as I can remember the problem was how the button bar was constrcuted in one of our dialogs. There was an additional composite around which leads to a shorter message line which is misaligned with the buttons. To see it open the override method dialog on a type and check some elements. You see the gray status line at the bottom which is misaligned with the button bar on the left hand side.
There are other issues which need to be addressed around error reporting, including layout etc. We need to be consistent across wizards and dialogs, and ensure the correct foreground colour is used consistently as well. We don't have time to do a systematic pass for v2, and the current behaviour is reasonable, except for a few known places where we could do a better job for layout. Defer to v3.
Reopen to investigate
Closing PR since platform postpones homogenous fix to 3.x
