Bug 96195 - [Intro] Link to install SWT examples from intro page installs 3.0 version
Summary: [Intro] Link to install SWT examples from intro page installs 3.0 version
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 3.1 RC4   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords: example
Depends on: 101569 101570
Blocks:
  Show dependency tree
 
Reported: 2005-05-20 19:24 EDT by Brock Janiczak CLA
Modified: 2005-10-03 11:47 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Janiczak CLA 2005-05-20 19:24:23 EDT 
Version: 3.1.0
Build id: I20050513-1415

In 3.1 the Shell control supports the SWT.TOOL style bit.  Could this be added
as a decoration style in the shell tab of the SWT Control example plugin?
Comment 1 Steve Northover CLA 2005-05-20 20:17:08 EDT 
Thought this was already done?
Comment 2 Brock Janiczak CLA 2005-05-20 20:37:21 EDT 
I couldn't find any issues for them, but i think i know what is wrong.  I
downloaded the examples using the intro link.  It is probably pointing to an
older version of the plugin.
Comment 3 Brock Janiczak CLA 2005-05-20 20:57:14 EDT 
I have confirmed that the wrong version is being instaleld from intro.  Updating
the title to reflect the real problem.

Would it be possible to have the link automatically point to the newest version?
It looks like this request may belong to PDE.
Comment 4 Brock Janiczak CLA 2005-05-20 21:34:11 EDT 
The problem appears to be in
org.eclipse.pde.ui.internal.samples#ShowSampleAction.  The feature version
(SAMPLE_FEATURE_VERSION) is hard coded to 3.0, so all examples it downloads will
be for 3.0.  The link in intro/samplesExtensionContent.xml (org.eclipse.pde)
doesn't/can't specify a feature version.

Can you please re-assign to PDE or intro?  I can't seem to do it (can't see the
correct components for the selected product)
Comment 5 Carolyn MacLeod CLA 2005-05-22 07:42:15 EDT 
Thanks, Brock.
Reassigning to Intro.
Carolyn
Comment 6 Mazen Faraj CLA 2005-05-22 12:45:35 EDT 
definitely an Intro polish item that we have delayed for a bit now. 
Will address.
Comment 7 Dejan Glozic CLA 2005-06-07 14:52:53 EDT 
We have made one pass and updated the samples. They all have the correct 
versions now and have been refreshed from HEAD i.e. are reasonably current (as 
of RC1).

We will make another pass near the end of 3.1 dev cycle to pick the final code 
from HEAD.
Comment 8 Dejan Glozic CLA 2005-06-21 10:12:34 EDT 
Note that refreshing the update site for this defect does not require any 
changes in code.
Comment 9 Dejan Glozic CLA 2005-06-23 19:48:35 EDT 
Refreshed the code from HEAD.

Waiting for SWT and Platform UI team to fix warnings in the code, but 
otherwise good to go as-is.
Comment 10 Dejan Glozic CLA 2005-06-23 22:43:43 EDT 
Platform UI team done, SWT team partially done. What's left are references to 
TableTree that has been deprecated in 3.1. I will refresh the SWT project and 
refresh again if TableTree references are removed.
Comment 11 Dejan Glozic CLA 2005-06-24 12:25:46 EDT 
Samples updated - closing.
Comment 12 Mazen Faraj CLA 2005-06-24 16:35:26 EDT 
verified