Community
Participate
Working Groups
If I use the synchronization view, it already shows all the changes to my code base, filterable according to whether they are incoming, outgoing or conflicting. When after examining the changes I decide to commit, I am presented with a large dialog that again summarizes the commit operation - showing the exact same information I had been looking at in the syncronization view all the time. This is completely redundant. There should be a unified concept of when to show what type of summary information.
This is something to think about. However, the preview does serve a purpose. It allows the user to exclude specific resources from the commit without removing them from the sync view. Perhaps the commit dialog, when launched from the sync view, could hide the preview by default but present an option to show it.
AFAICT I can make all the choices that are needed from the synchronization view (e.g., commit selectively), so in my view the commit dialog still is completely redundant.
Right, but to exclude one file from a list of 100 in the sync view requires you to either individually select 99 files or remove the 1 file from the sync view. The former is tedious and the later will remove the file from the sync view until it is modified again which is probably not what the user would want.
done this many times (option 2), never had any complaints. I never keep the synch view open for long anyway. I see a danger that eclipse is reaching a point where the feature-base is complete, and now the existing features get twisted according to the taste of whoever happens to own the commit rights (seen this elsewhere as well). The question remains for me whether the added convenience for those who want to keep a synch view stable and modify only the commit set justifies the fact that everyone now has to look at the same information twice. I also wonder whether wanting to remove individual files from a commit is such a common use case. After all, with other CVS clients you commit a file or a complete directory, period. I guess we're stuck. I'd be happy with a "Details>>>" button, but I still regard the whole thing as redundant.
The preview was added in order to have the ability to preview what is being committed when Team>Commit is executed from the Navigator. The work was done by a non-committer and contributed to the project. The decision was made to reuse this same dialog for commit from the sync view so that we would not be maintaining two dialogs (i.e. it was a pragmatic decision not some desire of the comitters to twist things). I commit from the sync view and have no problems ignoring the list. If you don't want to see it, you can set the Team>CVS/Maximum number of files to show when committing to 0 and you will never see the list again. I'll leave this bug open as a request to make the suppression of the list occur by default when committing from the sync view (although given the workaround above, it is a low priority for me). If you feel strongly about this, you can always submit a patch.
sorry to beat upon this, but let me summarize my understanding of the events that lead to this feature: Someone (the contributor) decided that she wanted to commit from the navigator, but get the same functionality as from the synch view. She either did not know the synch view, or for some reason did not like (to open) it. Instead, she created a new dialog that essentially duplicated the synch view. The workaround is ok for me, now that I know it.
after trying the "workaround", I must withdraw my previous statement. Even with "Maximum number of files to show when committing" set to 0, the commit dialog is monstrously large, taking up 2/3rds of the screen. Of course this is cosmetic. But I think that a good user interface design and consistency in the usage paradigm are very important properties of an IDE. My previous understanding of the Eclipse CVS handling paradigm was that if I wanted enhanced functionality (change set inspection/modification), I would go to the synch view. Everywhere else I would get basic CVS behavior (which is desirable for those who know CVS well). Now I have the enhanced stuff everywhere, and in the synch view I have it twice redundantly.
As of now 'LATER' and 'REMIND' resolutions are no longer supported. Please reopen this bug if it is still valid for you.
