Bug 95517 - ajc pseudo LTW not consistent with LTW
Summary: ajc pseudo LTW not consistent with LTW
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 1.5.0RC1   Edit
Assignee: Matthew Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-17 05:19 EDT by Alexandre Vasseur CLA
Modified: 2005-11-16 05:39 EST (History)
1 user (show)

See Also:


Attachments
Patch (2.57 KB, application/octet-stream)
2005-11-08 12:04 EST, Matthew Webster CLA
no flags Details
Patch (2.65 KB, application/octet-stream)
2005-11-15 09:55 EST, Matthew Webster CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Vasseur CLA 2005-05-17 05:19:40 EDT
docs says ajc provides LTW things, but that one does not at all go thru aop.xml
lookups and so on

Needs to be removed or made consistent in some way
Comment 1 Adrian Colyer CLA 2005-09-27 05:47:36 EDT
moved to P2.
Alex and Matthew, please can you work together to decide what we should do with
"aj" in the new world. Just rebasing it on the new LTW agents so that it obeys
the aop.xml etc. seems the simplest and best thing here?
Comment 2 Alexandre Vasseur CLA 2005-09-28 04:10:57 EDT
this won't solve the issue for java 1.3/1.4 since we decided to not have the AW
LTW in there but as an extension (see my blog).

I suggest to keep aj as it is (no aop.xml, based on aspect path etc)and possibly
have an aj5 script for use with java5 -javaagent and aop.xml

Matthew?
Comment 3 Matthew Webster CLA 2005-10-13 10:07:57 EDT
We could have 2 scripts: the existing "aj" and "aj5". They are both installed 
regardless of which JDK you specify during install. We will rely on any error 
messages from the JDK if someone uses the wrong one although 1.3 will fail 
silently.

- "aj" will use both aspectpath and aop.xml since my changes in 107741. We 
need to update the documentation and examples
- "aj5" will be a simple wrapper for "java -javaagent:aspectjweaver.jar ..." 
using aop.xml. We also need a implementation for bug 95516.
Comment 4 Adrian Colyer CLA 2005-10-28 05:31:13 EDT
Matthew, could you close this one out for RC1 pls? 
Comment 5 Matthew Webster CLA 2005-11-08 12:04:08 EST
Created attachment 29547 [details]
Patch

build: Modified installer to update aj.bat and add aj5.bat
docs:  New README and simple HelloWorld/Tracing example to illustrate aop.xml
support and new –outxml option
lib:   build/build.jar must be update. Build as follows:
-	Run “..\lib\ant\bin\ant build” from “from build module”
-	Copy “aj-build\jars\build.jar” to “lib\build”
-	Commit lib module

Can someone please test aj and aj5 on Linux/Mac
Comment 6 Matthew Webster CLA 2005-11-15 09:55:42 EST
Created attachment 29960 [details]
Patch

Now tested successfully on Mac after changing onUnix test to be true for Mac.
Comment 7 Andrew Clement CLA 2005-11-15 11:59:03 EST
patch integrated - waiting on build.
Comment 8 Andrew Clement CLA 2005-11-16 05:39:59 EST
fix available.