Community
Participate
Working Groups
to do as defined in docs (includes <weaver options=/> as the ones used in AJC + gather all aspects found (ie even those from aspectpatth etc)
assigning P2 in the run-up to AJ 5 RC1
This capability is being introduced in AJDT Bug 71066. Do we still need this enhancement?
I would think so for Ant ajc purpose f.e. ajc -outjar aop.jar Aspect.aj => aop.jar/META-INF/aop.xml TBD: - do we want to add an extra -outxml option to ajc or should it be default from now. - do we really want to have the ajc options written in aop.xml weaver options (I may want verbose or noinline now but may decide something different later on at deploy time etc). I 'd say we don't put any option in the gen. file
The primary use case for this will be Ant because AJDT has its own solution in bug 71066. I like the -outxml option but it should only produce <aspect> elements not <weaver>. The best approach would be for the user to create a template aop.xml with the required weaver options and include/excludes then _include_ the generated aop.xml. - Can we support this? - In the light of recent revelations concerning the side affects of abstract aspects (http://dev.eclipse.org/mhonarc/lists/aspectj-dev/msg01785.html) we need to include more that just concrete aspects in the generated aop.xml. Can we safely include all abstract aspects?
that is abstract aspect containing ITD should be in the aop.xml this reminds me that right now LTW issue a warning when abstract aspect is used in <aspect/> instead of <concrete-aspect/> This requires some change. Don't know what logic is best though.
I think we need to modes: one simple for use with -outjar the other where the user can specifiy the filename for more complex environments e.g. OSGi: 1. ajc -outxml -outjar=aspects.jar ... 2. ajc -outxmlfile org/aspectj/aop.xml ...
Created attachment 29336 [details] Patch, testcases and documentation ajde: testcase for -outxml and -outxmlfile docs: development guide org.aspectj.ajdt.core: add new options testing: support in harness tests: ltw functional tests
I will add Ant support in a separate patch.
Created attachment 29442 [details] Patch and testcases ajde: Test missing from first patch taskdefs: Ant support
Now that this enhancement is complete the patch added to bug 95529 (if it's too broken I'll fix it) needs to be integrated. The generated aop.xml file will contain a list of _all_ aspects including abstract ones because they can have side affects and are benign otherwise. The patch tests this and removes this existing warning in ClassLoaderWeavingAdaptor.
Patch integrated - will close this bug when build is available. Now going to take a look at 95529 to see if theres more to do there..
build available containing the patches.
