Bug 95155 - [Actions] Reduce the number of actions that listen to selections
Summary: [Actions] Reduce the number of actions that listen to selections
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, performance
Depends on:
Blocks:
 
Reported: 2005-05-13 12:22 EDT by Stefan Xenos CLA
Modified: 2019-09-06 16:08 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2005-05-13 12:22:37 EDT
Each selection change from workbench page is fired to hundreds (or thousands) of
listeners. Iterating over the listeners takes time, and most of the objects that
receive the selection events are actions.

Actions that need to update their enablement state based on the current
selection should only listen to selection changes when they are visible. Any
other action should only receive the selection at the time they are run.
Comment 1 Kim Horne CLA 2005-05-19 09:07:30 EDT
This would need to be co-ordinated across component teams.
Comment 2 Stefan Xenos CLA 2005-05-19 15:02:26 EDT
We could make big improvements in the workbench itself. Most actions are created
from XML (using RetargetAction, etc.). These things get hooked to a selection
listener, part listener, etc. automatically on creation and they stick around
effectively forever.

We could eliminate most of the listeners by automatically unhooking the
RetargetAction listeners when the action is hidden.
Comment 3 Eclipse Webmaster CLA 2019-09-06 16:08:57 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.