Bug 95100 - [Wizards] Double click on New>Untitled Text File should create it
Summary: [Wizards] Double click on New>Untitled Text File should create it
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.1 RC1   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-13 06:32 EDT by Tom Hofmann CLA
Modified: 2005-05-27 09:13 EDT (History)
2 users (show)

See Also:

Attachments
Patch against org.eclipse.ui.workbench (4.10 KB, patch)
2005-05-15 11:40 EDT, Kim Horne CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hofmann CLA 2005-05-13 06:32:22 EDT 
I20050512(-2036 or so)

- File>New>Other (Ctrl+N)
- double click on Simple>Untitled text file

> expected: a new file is created
< actual: nothing happens

note: pressing return works as expected
Comment 1 Kim Horne CLA 2005-05-15 11:39:24 EDT 
To make this work properly will require new API.   There is currently no way from within a wizard to 
explicitly closed it's IWizardContainer.  I can cast the container to a WizardDialog and call close and this 
should perform as expected, but it's a hack - close has the side effect of calling "cancel" on the wizard.  In 
the case of the New wizard this is a no-op, but this may change in the future.

I say we go with the hack for 3.1 and investigate introducing methods on IWizardContainer(3) to grant the 
ability to force close or abort on the container for 3.2.
Comment 2 Kim Horne CLA 2005-05-15 11:40:07 EDT 
Created attachment 21175 [details]
Patch against org.eclipse.ui.workbench

Patch that will fix this for 3.1
Comment 3 Kim Horne CLA 2005-05-15 11:48:27 EDT 
Incidentally, getting the fix for this to work uncovered a bug in NewWizardNewPage - we had two 
doubleclick listeners on the tree viewer that were doing similar work and could've been responsible for 
some flicker in the wizard.  Even if we don't do this fix we should probably address that for 3.1.
Comment 4 Kim Horne CLA 2005-05-16 09:01:10 EDT 
Patch submitted to head.  I've entered bug 95348 to track the possible need for new API.
Comment 5 Kim Horne CLA 2005-05-27 09:13:40 EDT 
Verified in I20050527-0010