Bug 94879 - [PropertiesDialog] [Preferences] Esc does not dismiss properties or preferences dialog
Summary: [PropertiesDialog] [Preferences] Esc does not dismiss properties or preferenc...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 RC1   Edit
Assignee: Michael Van Meekeren CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2005-05-11 22:13 EDT by Nick Edgar CLA
Modified: 2005-05-27 12:55 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-05-11 22:13:24 EDT
build I20050509-2010

- select a file in the Navigator and choose Properties
- after looking at the properties, press Esc to dismiss the dialog
- instead of dismissing the dialog, it clears the filter field
- pressing Esc again dismisses it

Same problem in the preferences dialog.

This is unexpected behaviour.  Esc is not normally used to clear a field.  Esc
within a dialog should dismiss it.

Suggest not intercepting Esc, and just allowing backspace to clear the field
(it's selected by default anyway).
Comment 1 Michael Van Meekeren CLA 2005-05-12 09:08:36 EDT
One issue here is that Enter will bring you to the tree.  

Common pattern.  User opens quickly types some text then slams on the enter key.
So since we override enter and don't close the dialog in that case, the thought
is that it might not be appreciated that it close on ESC.

thoughts?  I'm not married to this.
Comment 2 Nick Edgar CLA 2005-05-12 10:05:37 EDT
I think the current handling of Enter is OK, and the scenario above was
previously a problem when it dismissed.  It's actually pretty normal to
disable/override the default button when Enter is meaningful for the focus
control (see the MS UI guidelines).

But I think it's unexpected for Esc to clear a field, and to not dismiss the dialog.

So I would keep the current Enter handling, but revert the Esc handling.
Comment 3 Michael Van Meekeren CLA 2005-05-16 15:23:09 EDT
fixed in HEAD
Comment 4 Michael Van Meekeren CLA 2005-05-27 12:55:42 EDT
Version: 3.1.0
Build id: I20050527-0900