Community
Participate
Working Groups
Local configuration config.ini uses an absolute path to refer to the shared configuration. This hampers the ability of moving the install when local configurations exist. It should use an install relative path instead.
The property name is: osgi.sharedConfiguration.area. Should investigate for M7.
*** This bug has been marked as a duplicate of 88699 ***
org.eclipse.osgi is not ready for this yet. Should be addressed in separate of bug 88699.
The patch for bug 88699 must be applied before this can be fixed.
Created attachment 21534 [details] patch for org.eclipse.update.configurator
The patch includes the changes proposed to bug 88699. If this is committed, that one does not have to.
Moving back to Update inbox and requesting review. This changes need to be coordinated with the changes from bug 95223.
Thanks Rafael, the patch looks good. I don't have the "luxury" to any more than a simple test, and given the late development cycle, I'd suggest getting some extra testing for the other folks familiar with update (Dejan, Konrad, Branko).
Any chance this will be looked at soon enough for RC1? If you need any help from my side, just let me know.
The patch to bug 94746 includes these changes, so if that one is fixed, this one won't require any further work.
Please ignore the comment above, it was intended for bug 88699.
so what is the status here?
As I mentioned in comment #8, the patch looks fine to me, but this requires some extra testing, given that the code is on the critical path. I give it a +1 with the reservation that Dejan is ok with it as well. I only did minimal testing and need others to verify it more.
Branko, we need to raise the level of confidence that this patch is not going to introduce regressions. Please put Update through some tests and see if you get anything out of the ordinary (including re-running all the JUnit tests).
Please note that this patch requires org.eclipse.osgi and org.eclipse.platform from HEAD or from tonight's build. It does not hurt to say also (again) that if this patch is released bug 88699 is automatically fixed.
I ran all junit tests for update and went through some manual GUI based tests. The patch looks just fine. Dejan, how should we procced now?
OK then, lets apply it and watch carefully for any strange glitches when we do RC1 testing.
patch released
Thanks! Aren't you going to close it now?
FIXED, we should also mark bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=88699 as fixed
