Bug 94164 - [Undo] - Action handlers should provide progress monitor for sharing by operation approvers
Summary: [Undo] - Action handlers should provide progress monitor for sharing by opera...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 94166
Blocks:
  Show dependency tree
 
Reported: 2005-05-09 13:15 EDT by Susan McCourt CLA
Modified: 2019-09-06 15:38 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2005-05-09 13:15:29 EDT
If the action handlers provided their progress monitor and runnable context in 
the uiInfo adaptable, then operation approver clients could use the same 
progress monitor or runnable context when approving an operation, rather than 
creating one themselves.

Specifically, this would let the undo/redo action handlers share a progress 
monitor with AdvancedValidationUserApprover.
Comment 1 Susan McCourt CLA 2005-05-09 13:16:26 EDT
released to HEAD.
Should appear in 20050509 4pm EDT build.
Comment 2 Susan McCourt CLA 2005-05-09 13:28:30 EDT
Backing out this change.  It goes against the spec for ProgressMonitorDialog, 
which does not support reusing the dialog for runnables.  This would be a nice 
enhancement for the future.  See bug #94166.
Comment 3 Susan McCourt CLA 2005-05-24 14:34:22 EDT
Consider using subtasks in the future?  Simply reusing the dialog doesn't help 
because the operation approver's work is nested inside the running of the 
action handler.
Comment 4 Susan McCourt CLA 2005-05-24 15:22:46 EDT
Discussed problem with Tod.  Ideally a SubProgressMonitor could be used, but 
the current implementation provided by the runtime plug-in assumes that the 
creator of a SubProgressMonitor knows how many ticks in the parent the sub 
monitor will use.  This is not the case.  In fact, it's not even clear how 
many sub monitors would be used (for example, if there were multiple operation 
approvers each using the monitor for something different).  Further, the 
operation approvers run before the operation is ever given the monitor, so 
there hasn't even been a total number of ticks established.


The dialog used for this scenario will need to be smarter.  I'll update bug 
#94166 with new info.
Comment 5 Susan McCourt CLA 2005-05-24 15:28:55 EDT
Notes for the future:
Consider a dialog whose monitor could handle multiple begin task/tick/done 
sequences, creating a new sub progress monitor each time, so that each client 
could treat the monitor as if it were brand new.  

It would seem we'd still have to guess about the total number of ticks 
needed...
Comment 6 Susan McCourt CLA 2009-07-09 15:56:40 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 7 Eclipse Webmaster CLA 2019-09-06 15:29:55 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 8 Eclipse Webmaster CLA 2019-09-06 15:38:34 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.