Bug 93840 - [Help] Dynamic Help menu item does not show the accelerator
Summary: [Help] Dynamic Help menu item does not show the accelerator
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2005-05-05 15:39 EDT by Dejan Glozic CLA
Modified: 2005-05-10 18:23 EDT (History)
0 users

See Also:

Attachments
The patch for F1 to show up on Dynamic Help on WIN32 (5.26 KB, patch)
2005-05-05 15:39 EDT, Dejan Glozic CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dejan Glozic CLA 2005-05-05 15:39:24 EDT 
This has been a long story about Help keys being different on different WSs. 
However, we DO know that F1 is the accelerator used for dynamic help on 
Windows and that users cannot change it (unlike on Carbon or GTK+).

I will attach a patch that adds F1 to the menu item label on Windows. Note 
that we cannot use key bindings because the accelerator is implied - we should 
not process the key ourselves.
Comment 1 Dejan Glozic CLA 2005-05-05 15:39:59 EDT 
Created attachment 20756 [details]
The patch for F1 to show up on Dynamic Help on WIN32
Comment 2 Dejan Glozic CLA 2005-05-05 15:40:24 EDT 
I already know this goes to Nick :-).
Comment 3 Nick Edgar CLA 2005-05-05 16:13:43 EDT 
ActionFactory.DYNAMIC_HELP is available for other RCP apps to use.
Do RCP apps need to do anything special to get F1 to map to dynamic help?
If extra steps are needed, then the action should not show F1 without checking.
Comment 4 Dejan Glozic CLA 2005-05-05 16:18:00 EDT 
No, F1 is always hooked to dynamic help - the label just spells it out. RCPs 
cannot change that fact and do not need to do anything special.
Comment 5 Nick Edgar CLA 2005-05-06 10:19:57 EDT 
Patch applied then.  In future, please do not include a reformat in the patch,
to make it easier to see the actual changes.
Comment 6 Dejan Glozic CLA 2005-05-06 11:35:27 EDT 
Sorry - force of habbit. Will be more careful in the future.
Comment 7 Nick Edgar CLA 2005-05-10 18:23:51 EDT 
Verified in I20050509-2010.