Bug 93449 - CVS action enablement is very slow with large number of items
Summary: CVS action enablement is very slow with large number of items
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-05-02 16:06 EDT by Tod Creasey CLA
Modified: 2005-05-10 11:22 EDT (History)
0 users

See Also:

Attachments
Trace output of the popup (56.10 KB, text/html)
2005-05-02 16:07 EDT, Tod Creasey CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2005-05-02 16:06:56 EDT 
20050426 running self hosted with jface and SWT loaded from HEAD.

Profiled with OptimizeIt (likely faster without profiling)

STEPS
1) load win32.x86 plugin
2) Select all of the classes in org.eclipse.swt.internal.win32
3) Pop up the menu

Of the 3662ms it look to show 2404 was spent in CVSAction#selectionChanged
Comment 1 Tod Creasey CLA 2005-05-02 16:07:30 EDT 
Created attachment 20605 [details]
Trace output of the popup
Comment 2 Michael Valenta CLA 2005-05-03 09:25:51 EDT 
Which plugin is the win32.x86 plugin? I have an 
org.eclipse.swt.win32.win32.x86 plugin but it doesn't have any Java packages. 
I did look at the org.eclipse.swt.internal.win32 package in the 
org.eclipse.swt plugin. Opening up a context menu on all the items is not 
instantanious but takes less than a second.
Comment 3 Tod Creasey CLA 2005-05-03 09:31:53 EDT 
My mistake - it is in the win32 package of the SWT plug-in
Comment 4 Michael Valenta CLA 2005-05-06 11:47:37 EDT 
I was able to improve the performance by caching often calculated values in a 
WeakHashMap. This allows the calculation to be shared accross actions.
Comment 5 Michael Valenta CLA 2005-05-10 11:22:26 EDT 
Verified