Bug 93115 - [ActivityMgmt] Possible optimization for context menu contribution items
Summary: [ActivityMgmt] Possible optimization for context menu contribution items
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-04-28 09:16 EDT by Kim Horne CLA
Modified: 2007-06-22 10:59 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2005-04-28 09:16:25 EDT 
Items for context menus are created every time the menu is shown.  As such, the
support we have in PluginActionContribution item for listening to activity and
identifier changes is a heavy.  The activity state will never change while the
context menu is shown so adding the listeners is a waste, particularly since
doing so causes the lazy creation of the identifier listener list.  We should
bench the opening of a context menu and see how much time/memory is wasted in
these unnecessary calls.
Comment 1 Kim Horne CLA 2007-06-22 10:59:56 EDT 
The items are more persistent in the new menu story and our behaviour makes sense there.