Bug 92850 - [JFace] [api] public API non-constant field ColumnPixelData.addTrim
Summary: [JFace] [api] public API non-constant field ColumnPixelData.addTrim
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2005-04-26 18:45 EDT by Jim des Rivieres CLA
Modified: 2005-04-28 10:53 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim des Rivieres CLA 2005-04-26 18:45:48 EDT
3.1 HEAD

ColumnPixelData
public boolean addTrim

This read-write field was added as API in the 3.1 cycle. Exposing fields as 
API (other than public static final ones) is bad practice because a client can 
change the field and there's nothing the class can do to prevent or even track 
that change. All access to read-write field should be through accessor method.
Comment 1 Tod Creasey CLA 2005-04-28 10:19:02 EDT
This was added by Nick to fix Bug 90712. Moving to Nick
Comment 2 Nick Edgar CLA 2005-04-28 10:53:32 EDT
I'm aware of the limitations of using fields, but it's a fairly common practice
in layouts to do this (e.g. see GridData and other SWT layout data classes).

In this case, it's just a signal to the layout class to do some extra adjustment.
I think we should just leave as-is for 3.1.