Description Roland Tepp 2005-04-13 09:48:21 EDT

Mergeing a long set of changes one late sleepy afternoon I noticed that the
order of "Copy.." buttons above compare split view have rather dangerous ordering.

Currently they are positioned in a following order:

   [|=>] [<=|] [->] [<-]

I used (for brievity's sake) the following legend:
[|=>] - "Copy All from Left ot Right"
[<=|] - "Copy All Non-Conflicting Changes from Right to Left"
[->]  - "Copy Current Change from Left to Right"
[<-]  - "Copy Current Change from Right to Left"

Now what I noticed is that the button "Copy All Non-Conflicting Changes from
Right to Left" is just next to the button "Copy Current Change from Left to
Right".  And since the default button sixe in Eclipse is rather small (16 pixels
if I'm not mistaken), the distance between those two buttons is dangerourly
close and might (and in my case did) cause one pressed instead of the other.

I must tell that I found it rather frustrating, when trying to copy a single
change from left to right, I managed to copy the entire content of the right
document into left... 

I admit, this kind of mistake is easily fixable and I should (and will) try to
be more careful when merging documents henceforth, but nevertheless, the
position of those buttons is helping me to make such mistakes.

I suggest a new order for copy buttons be following (same legend applies):

   [|=>] [->] [<-] [<=|]

This would at least minimize the impact of missing the intended mouse target to
either scope of a single change or at least same copy direction.

PS: Current button order might easily cause a dataloss in some situations (eg.
late-night-coding-fatique, no-morning-coffe-syndrome, etc.), which is Really Bad
Thing(TM) imho.