Bug 90777 - [Themes] [EditorMgmt] Overriding org.eclipse.ui.workbench.INACTIVE_TAB_BG_END does not work for editor tabs
Summary: [Themes] [EditorMgmt] Overriding org.eclipse.ui.workbench.INACTIVE_TAB_BG_END...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2005-04-08 06:27 EDT by Setya Nugdjaja CLA
Modified: 2021-10-08 14:28 EDT (History)
2 users (show)

See Also:


Attachments
Screenshot when the editor is active (87.24 KB, image/bmp)
2005-04-08 06:49 EDT, Setya Nugdjaja CLA
no flags Details
Screenshot 2 when the view is active (67.39 KB, image/bmp)
2005-04-08 06:50 EDT, Setya Nugdjaja CLA
no flags Details
Screenshot 3 expected tab color on inactive editor (29.93 KB, image/bmp)
2005-04-08 06:52 EDT, Setya Nugdjaja CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Setya Nugdjaja CLA 2005-04-08 06:27:56 EDT
Hi, 

I try to change the background color of tabs when they're not active by putting
the following extensions in my plugin.xml :

<theme id="com.farbeyond.core.themes" name="Application Theme">
<colorOverride id="org.eclipse.ui.workbench.INACTIVE_TAB_BG_END
value="COLOR_RED"/>
</theme>

(I know red is not appropriate color, but it's an example to show my point).

The above extension works on tabs of views, i.e their background color turns
into red when they're inactive, but it does not work on tabs of editors as their
colors stays white, the editor tabs seem to ignore the extensions.

Best Regards,


Setya
Comment 1 Setya Nugdjaja CLA 2005-04-08 06:49:19 EDT
Created attachment 19678 [details]
Screenshot when the editor is active
Comment 2 Setya Nugdjaja CLA 2005-04-08 06:50:33 EDT
Created attachment 19679 [details]
Screenshot 2 when the view is active
Comment 3 Setya Nugdjaja CLA 2005-04-08 06:52:55 EDT
Created attachment 19680 [details]
Screenshot 3 expected tab color on inactive editor
Comment 4 Setya Nugdjaja CLA 2005-04-10 07:11:52 EDT
(In reply to comment #0)
> Hi, 
> I try to change the background color of tabs when they're not active by 
putting
> the following extensions in my plugin.xml :
> <theme id="com.farbeyond.core.themes" name="Application Theme">
> <colorOverride id="org.eclipse.ui.workbench.INACTIVE_TAB_BG_END
> value="COLOR_RED"/>
> </theme>
> (I know red is not appropriate color, but it's an example to show my point).
> The above extension works on tabs of views, i.e their background color turns
> into red when they're inactive, but it does not work on tabs of editors as 
their
> colors stays white, the editor tabs seem to ignore the extensions.
> Best Regards,
> Setya

FYI, overriding org.eclipse.ui.workbench.INACTIVE_TAB_BG_START works for both 
view and editor tabs.

Regards,

Setya
Comment 5 Kim Horne CLA 2005-04-18 09:40:21 EDT
We treat editors a bit special so that the active non-focus editor can be distinguished from other visible 
editors when there is more than one editor area.  We should expose this colour via themes but we dont 
currently do it.  I doubt we will have time to address this for 3.1.
Comment 6 Setya Nugdjaja CLA 2005-04-18 22:33:57 EDT
(In reply to comment #5)
> We treat editors a bit special so that the active non-focus editor can be 
distinguished from other visible 
> editors when there is more than one editor area.  We should expose this 
colour via themes but we dont 
> currently do it.  I doubt we will have time to address this for 3.1.

(In reply to comment #5)
> We treat editors a bit special so that the active non-focus editor can be 
distinguished from other visible 
> editors when there is more than one editor area.  We should expose this 
colour via themes but we dont 
> currently do it.  

Actually we use editor parts for our data-centric form, not for editing file. 
That's why we don't want to have white as background, moreover we avoid using 
Eclipse Form API. 

Do you think editor is appropriate to be used for data-centric apps.

>I doubt we will have time to address this for 3.1.

So I have to wait for 3.2 ?


Regards,

Setya
Comment 7 Kim Horne CLA 2005-04-19 06:16:39 EDT
(In reply to comment #6)
> 
> Actually we use editor parts for our data-centric form, not for editing file. 
> That's why we don't want to have white as background, moreover we avoid using 
> Eclipse Form API. 
>
> Do you think editor is appropriate to be used for data-centric apps.

Yes, this is reasonable.

> 
> >I doubt we will have time to address this for 3.1.
> 
> So I have to wait for 3.2 ?

Yes.  Alternatively you could implement your own presentation.  Presentations
control how views and editors are displayed within the workbench.  Stefan, are
there any documents for presentations available?  I should mention that doing
this is NOT a trivial task...

> 
> 
> Regards,
> 
> Setya

Comment 8 Setya Nugdjaja CLA 2005-09-06 04:17:35 EDT
(In reply to comment #7)
> (In reply to comment #6)
> > 
> > Actually we use editor parts for our data-centric form, not for editing file. 
> > That's why we don't want to have white as background, moreover we avoid using 
> > Eclipse Form API. 
> >
> > Do you think editor is appropriate to be used for data-centric apps.
> 
> Yes, this is reasonable.
> 
> > 
> > >I doubt we will have time to address this for 3.1.
> > 
> > So I have to wait for 3.2 ?
> 
> Yes.  Alternatively you could implement your own presentation.  Presentations
> control how views and editors are displayed within the workbench.  Stefan, are
> there any documents for presentations available?  I should mention that doing
> this is NOT a trivial task...
> 
> > 
> > 
> > Regards,
> > 
> > Setya
> 
> 

When will this bug be resolved in 3.2 ?

Regards,

Setya
Comment 9 Kim Horne CLA 2005-09-06 08:31:54 EDT
It's not so much a matter of when, but if.  We haven't yet allocated any time for this problem.  If you have a 
patch that can accomplish what you're asking for we would consider it.
Comment 10 Trevor CLA 2007-08-08 11:42:37 EDT
This seems to still be a bug in Eclipse 3.3, any sort of timeline for a fix? 
Comment 11 Kim Horne CLA 2007-08-08 11:49:17 EDT
There is no timeline at this time but we will entertain patches.
Comment 12 Trevor CLA 2007-08-08 12:02:47 EDT
Okay, I will take a look. I'm fairly new and can't promise anything. 

Currently thinking of trying to provide an additional set of colour preferences in order to colour the active non-focus editor different from a non-active non-focus visible editor, would this be a good idea? 
Comment 13 Kim Horne CLA 2007-08-08 12:31:23 EDT
Any changes to our color schemes will need to be run past Kevin.
Comment 14 Boris Bokowski CLA 2009-11-17 11:34:06 EST
Susan is now responsible for watching the [Themes] category.
Comment 15 Eclipse Webmaster CLA 2019-09-06 15:32:50 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 16 Eclipse Genie CLA 2021-10-08 14:28:48 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.