Bug 90737 - "Terminate All" action should be renamed to "Terminate/Disconnect All"
Summary: "Terminate All" action should be renamed to "Terminate/Disconnect All"
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2005-04-07 18:16 EDT by Pawel Piech CLA
Modified: 2007-09-28 12:46 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2005-04-07 18:16:54 EDT
The "Terminate All" action works by recursively going through all the launches
and debug targets in the debugger and calling canTerminate() then terminate(). 
If canTerminate() returns false, debugger calls canDisconnect() followed by
disconnect().  So the action doesn't perform as advertized and should renamed.

We have a debugger in which the debug target cannot be terminated, but the
threads under the target can be.  When "Terminate All" is called, some users
expect that all of their threads will be terminated, while others expect that
the debug target will be disconnected.  Hopefully just renaming the action to
say what it actually does will solve the problem, but alternatively the action
could be split into two "Terminate All" and "Disconnect All" which would do what
they say.
Comment 1 Darin Wright CLA 2005-04-08 12:43:42 EDT
Deferred for post 3.1 consideration.
Comment 2 Curtis Windatt CLA 2007-09-21 16:43:51 EDT
Reopening to consider sometime in 3.4.  Action can be renamed to "Terminate/Disconnect All".  Help topic for this item should be updated as well (since it currently says nothing about it disconnecting if terminate fails.  Other terminate actions, such as terminate and remove, should be checked to see if they attempt a disconnect.
Comment 3 Curtis Windatt CLA 2007-09-28 11:39:21 EDT
Fixed in HEAD.  Updated ActionMessages.properties.  Updated help (both context file and html).
Comment 4 Curtis Windatt CLA 2007-09-28 11:39:37 EDT
Mike, please verify.
Comment 5 Michael Rennie CLA 2007-09-28 12:46:28 EDT
updated links for commands that link to the Terminate All/Disconnect All

verified