Bug 89900 - [Progress] showInDialog blocks if the parentShell is modal
Summary: [Progress] showInDialog blocks if the parentShell is modal
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-31 16:47 EST by Tod Creasey CLA
Modified: 2005-05-12 09:56 EDT (History)
1 user (show)

See Also:

Attachments
Appy this patch to test (23.49 KB, patch)
2005-04-20 08:59 EDT, Tod Creasey CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2005-03-31 16:47:47 EST 
20050331

IProgressService#showInDialog blocks until all modal shells are closed. This
will mean that it will not open if it is called on a modal parent.

ProgressMonitorFocusJobDialog should check if the shell blocking it is the
specified parent - if so then it should proceed.

We also should remove the code that looks for a non modal parent in the null
case and fall through to the new shell provider.
Comment 1 Tod Creasey CLA 2005-04-01 06:58:53 EST 
Adding Kevin as he way want to switch to showInDialog when this is fixed.
Comment 2 Tod Creasey CLA 2005-04-20 08:59:00 EDT 
Created attachment 20117 [details]
Appy this patch to test

This patch will make the keep next button on the Workbench preference page run
a showInDialog.
Comment 3 Tod Creasey CLA 2005-04-20 08:59:51 EDT 
Fixed in build >20050420. I have also attached a patch so that we can verify
using the preference dialog.

Kevin if you have a debug use case we can also use to verify please describe it
here.
Comment 4 Kevin Barnes CLA 2005-04-20 12:04:45 EDT 
We solved our problem by using a ProgressMonitorDialog. We were calling busyCursorWhile() from a 
preference page and not getting the dialog until the preference dialog had been dismissed. I don't have 
a use case for showInDialog().
Comment 5 Tod Creasey CLA 2005-05-12 09:56:47 EDT 
Verified in 20050510