Bug 89637 - [RCP] Need regression test for new advisor saveState/restoreState APIs
Summary: [RCP] Need regression test for new advisor saveState/restoreState APIs
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Michael Van Meekeren CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2005-03-30 13:28 EST by Nick Edgar CLA
Modified: 2005-05-12 08:59 EDT (History)
1 user (show)

See Also:

Attachments
first pass at unit test for save/restore API (13.89 KB, patch)
2005-03-30 15:35 EST, Matthew Hatem CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-03-30 13:28:04 EST 
build I20050330

The new API described in bug 85373 needs to have tests in the RCP test suite.
See bug 85373 comment 37 and 38.

Matt, would you be able to do this for M6 or M7?
Comment 1 Matthew Hatem CLA 2005-03-30 14:03:35 EST 
Yes, I have one in the works now, almost complete, I agreed to this in 85373.  I
would say okay for M6 but looks like you have specified M7 already.  Please
advise, I can post the patch today.
Comment 2 Nick Edgar CLA 2005-03-30 14:53:23 EST 
Extra tests can go in pretty well any time, so if it's ready, please attach.
Thanks.
Comment 3 Matthew Hatem CLA 2005-03-30 15:35:54 EST 
Created attachment 19371 [details]
first pass at unit test for save/restore API

This could be better.  I could consolidate the life cycle tests into one test
and the test for the save on demand API should check for something other than a
null window.  It should modify some aspect of the Window state, save, restore,
and check for those modifications.
Comment 4 Nick Edgar CLA 2005-03-30 16:10:32 EST 
What fun, eh?  When was the last time you got to create a triply-nested local
class? ;-)
Comment 5 Nick Edgar CLA 2005-03-30 16:15:47 EST 
The patch looks fine to me.
MvM, could you review as well?
Comment 6 Michael Van Meekeren CLA 2005-04-01 10:36:14 EST 
Looks good.  I would be helpful for me to see a few more comments 
- class comment - what does this class do what does it test?
- life cycle comments
   - now saving the state
   - now restore the state and try to create etc...
Comment 7 Michael Van Meekeren CLA 2005-04-14 10:08:24 EDT 
The code has been committed.  Matthew, it would still be nice to have a nicer
commented version of the test etc... when you get a chance.
Comment 8 Michael Van Meekeren CLA 2005-05-12 08:59:05 EDT 
verified in HEAD