Bug 89606 - [Viewers] Remove protected API added to support prototype of grouping by working sets
Summary: [Viewers] Remove protected API added to support prototype of grouping by work...
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 102440
  Show dependency tree
 
Reported: 2005-03-30 12:06 EST by Nick Edgar CLA
Modified: 2009-09-02 14:36 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-03-30 12:06:20 EST 
build I20050330

The API added to support the Package Explorer's grouping by working sets needs
to remain in for 3.1, since we're not backing out of this enhancement for 3.1.

However, these methods have been tagged as experimental and intended only to
support JDT's scenario (see bug 89137).

Need to review/remove these post-3.1.

See bug 76482 for more details.
Comment 1 Nick Edgar CLA 2005-03-30 12:06:54 EST 
Debug is also using these methods.  See bug 80321.
Comment 2 Gunnar Wagenknecht CLA 2006-02-02 03:38:38 EST 
Will there be new API in 3.2? The JavaDoc promises "proper support for multiple equal elements".

We need this support in our model specific tree views. I created a MultiTreeView some time ago, which overwrites/copies/duplicates a lot of internal stuff. It's now easier with this interims API. However, I would appreaciate a stable API.
Comment 3 Kim Horne CLA 2006-02-02 06:24:01 EST 
I wont have time to look at this for 3.2, however, it's more properly in Boris' component area anyway.  Boris, is this something you'd be interested in looking at?
Comment 4 Boris Bokowski CLA 2006-02-02 08:36:07 EST 
Re comment #2: Support for multiple equal elements is already implemented, see bug 84314.
Comment 5 Boris Bokowski CLA 2006-02-02 08:38:25 EST 
Darin, Dirk, do you still use these methods in JDT or Debug?
Comment 6 Darin Wright CLA 2006-02-02 09:15:36 EST 
Debug does not use these method anymore.
Comment 7 Dirk Baeumer CLA 2006-02-02 10:05:52 EST 
No, I am still overriding some methods due to bug 125708.
Comment 8 Boris Bokowski CLA 2006-02-13 20:35:42 EST 
Sorry, I did not have enough time to coordinate this for M5. Nick, do you think we should still try to get rid of this for 3.2, or would you prefer to leave it in for 3.2?
Comment 9 Nick Edgar CLA 2006-02-14 10:21:20 EST 
I don't think it's critical for 3.2.
Comment 10 Boris Bokowski CLA 2006-02-14 11:27:07 EST 
Removing target milestone.
Comment 11 Boris Bokowski CLA 2007-06-21 13:56:26 EDT 
Giving up on this - we now officially support subclassing AbstractTreeViewer, and there are multiple classes overriding these methods.
Comment 12 Stephan Herrmann CLA 2009-08-31 07:48:45 EDT 
(In reply to comment #11)
> Giving up on this - we now officially support subclassing AbstractTreeViewer,
> and there are multiple classes overriding these methods.

How about removing/updating the comment in AbstractTreeViewer?
At least the part 
  "This support will likely be removed in Eclipse 3.2 in 
  favor of proper support for multiple equal elements"
looks funny even post 3.5 ;-)
Comment 13 Boris Bokowski CLA 2009-09-02 14:36:11 EDT 
(In reply to comment #12)
> How about removing/updating the comment in AbstractTreeViewer?
> At least the part 
>   "This support will likely be removed in Eclipse 3.2 in 
>   favor of proper support for multiple equal elements"
> looks funny even post 3.5 ;-)

Good point. I have updated the JavaDoc.