Bug 89024 - 3.1 API review -Help
Summary: 3.1 API review -Help
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC1   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2005-03-24 14:08 EST by Michael Van Meekeren CLA
Modified: 2005-05-24 14:35 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Van Meekeren CLA 2005-03-24 14:08:07 EST
IWorkbenchHelpSystem
  - method search - please explain what a search expression looks like
	/**
	 * Starts the search using the help search system.
	 * <p>
	 * Ignored if no help UI is available.
	 * </p>
	 * @param expression the search expression
	 */	
	void search(String expression);

  - method displayContext(IContext context, int x, int y);
    - is there any guarantee that x,y are honored?
  - method displayHelpResource talked about String/href/URL is a bit confusing

WorkbenchHelp
  - all methods should just refer to javadoc in interface?
Comment 1 Kim Horne CLA 2005-03-24 15:50:31 EST
I have no idea what the search method is.  Dejan?
Comment 2 Dejan Glozic CLA 2005-03-24 16:27:30 EST
Search method activates help UI with the search expression. In 3.1, it opens 
the new Help view with the 'Search' page shown and immediately starts the 
search. The action is equivalent to showing the Help view manually, switching 
to Search page, typing the expression in the expression entry and hitting 'Go'.

The actual expression syntax is really dependent on the Help UI 
implementation. I don't think we can assume any particular expression syntax 
beyond claiming that it is a string.
Comment 3 Michael Van Meekeren CLA 2005-03-24 17:42:01 EST
I still think we should then explain how the expression depends on the help
support and to look there for more information.
Comment 4 Kim Horne CLA 2005-05-12 10:37:10 EDT
Punting to Dejan for final comment.
Comment 5 Dejan Glozic CLA 2005-05-12 12:58:50 EDT
Added the following to the Javadoc:

	/**
	 * Starts the search using the help search system.
	 * <p>
	 * Ignored if no help UI is available.
	 * </p>
	 * 
	 * @param expression
	 *            the search expression. The actual syntax rules of the
	 *            expression are dependent on the active
	 *            help system. Refer to the help system
	 *            documentation for more details.
	 */
	void search(String expression);
Comment 6 Dejan Glozic CLA 2005-05-24 14:35:18 EDT
Closing.