Bug 86848 - [Launcher] ppc (and presumably other arches) don't have icon.xpm
Summary: [Launcher] ppc (and presumably other arches) don't have icon.xpm
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.3   Edit
Hardware: Power PC Linux-GTK
: P3 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: contributed
: 227711 258073 259709 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-02-28 11:30 EST by Andrew Overholt CLA
Modified: 2018-11-12 03:02 EST (History)
14 users (show)

See Also:


Attachments
hacky patch to copy the icon over from x86 (757 bytes, patch)
2005-02-28 11:38 EST, Andrew Overholt CLA
no flags Details | Diff
48x48 PNG of the Eclipse icon (3.73 KB, image/png)
2005-05-13 10:42 EDT, Andrew Overholt CLA
no flags Details
Freedesktop menu entry file (201 bytes, application/x-desktop)
2005-05-13 11:10 EDT, Andrew Overholt CLA
no flags Details
patch (6.30 KB, patch)
2008-01-16 11:58 EST, Kim Moir CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2005-02-28 11:30:56 EST
icon.xpm is distributed in the x86 and x86_64 directories (for Linux-GTK) but
isn't copied over during build/install for other architectures such as ppc. 
Since build machinery exists for these platforms, it'd be cool if the icon could
also get copied over to the same place.

I'll attach a patch of what I've done in the mean time for our non-x86{,_64}
builds (untested so far .. it's building now).  I know it's a hack, so any
advice is appreciated.

Thanks,

Andrew
Comment 1 Andrew Overholt CLA 2005-02-28 11:38:24 EST
Created attachment 18365 [details]
hacky patch to copy the icon over from x86
Comment 2 Sonia Dimitrov CLA 2005-03-14 10:47:15 EST
Moving to SWT since we would need to include this file in other subdirectories
in the platform-launcher project to fix.
Comment 3 Christophe Cornu CLA 2005-03-15 15:37:59 EST
The icon.xpm is apparently useless on linux and should be removed.

Other platforms like Solaris Sparc has 4 special icons (Eclipse.m.pm file etc).

Andrew - do you have suggestions to be friendly with the linux desktop 
regarding the launcher icon? Otherwise we'll just remove the icon.xpm which 
does nothing at the moment.
Comment 4 Andrew Overholt CLA 2005-03-17 17:48:16 EST
This is what we currently do during our RPM build:

# rh/freedesktop.org icons
install -p -D -m0644 eclipse-48.gif \
  /usr/share/icons/hicolor/48x48/apps/eclipse.png
install -p -D -m0644 eclipse-32.gif \
  /usr/share/icons/hicolor/32x32/apps/eclipse.png
install -p -D -m0644 eclipse-16.gif \
  /usr/share/icons/hicolor/16x16/apps/eclipse.png
install -d -m0755 /usr/share/pixmaps
ln -s ../icons/hicolor/48x48/apps/eclipse.png \
  /usr/share/pixmaps

Perhaps shipping icons in the same sizes in PNG format would work?  I'm just
getting some opinions from some of the people more in the know with this and
will post more soon.
Comment 5 Andrew Overholt CLA 2005-04-21 13:54:39 EDT
Sorry for taking so long on this.  I spoke with some people who work on GNOME
and they said that we should just ship PNGs.  I'm in favour of removing icon.xpm
and replacing it with icon.png (48x48).
Comment 6 Pascal Rapicault CLA 2005-05-12 17:30:24 EDT
Please provide icons to the releng team.
Comment 7 Andrew Overholt CLA 2005-05-13 10:42:43 EDT
Created attachment 21106 [details]
48x48 PNG of the Eclipse icon
Comment 8 Andrew Overholt CLA 2005-05-13 11:10:24 EDT
Created attachment 21114 [details]
Freedesktop menu entry file

While we're at it, it would be cool if we could also include a freedesktop.org
menu entry file for Eclipse.  I've attached the one that JPackage.org, Fedora
and RH use.
Comment 9 Sonia Dimitrov CLA 2005-06-23 16:40:13 EDT
Moving back to SWT since the files should be placed in the appropriate 
locations in the platform-launcher project.
Comment 10 Andrew Overholt CLA 2006-01-30 12:12:50 EST
Any news on this?  It would be great to get this fixed before 3.2 final.
Comment 11 Pascal Rapicault CLA 2006-03-30 17:20:43 EST
Andrew, could you precisely tell where in an eclipse tree these icons should be installed?
Comment 12 Andrew Overholt CLA 2006-03-30 18:02:21 EST
(In reply to comment #11)
> Andrew, could you precisely tell where in an eclipse tree these icons should be
> installed?

It looks like they're already included:

http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.platform/eclipse32.png?cvsroot=Eclipse_Project

As for the .desktop file, Ben remembers Billy saying something about it last week.  Billy?
Comment 13 Billy Biggs CLA 2006-03-30 19:13:53 EST
The problem with .desktop files is that they require an
absolute path.  Since we're not shipping an installer, it is
a little awkward to provide a .desktop file since it will
look like something you can just use when in reality it
may require editing.

Andrew, do you agree with that?  Maybe you can try it
out and verify?
Comment 14 Andrew Overholt CLA 2006-04-04 12:25:33 EDT
(In reply to comment #13)
> The problem with .desktop files is that they require an
> absolute path.  Since we're not shipping an installer, it is
> a little awkward to provide a .desktop file since it will
> look like something you can just use when in reality it
> may require editing.
> 
> Andrew, do you agree with that?

I agree.  Thanks.
Comment 15 Sonia Dimitrov CLA 2006-04-28 10:08:12 EDT
Based on comment #12, I believe this can be closed.
Comment 16 Andrew Overholt CLA 2006-12-05 14:59:16 EST
(In reply to comment #15)
> Based on comment #12, I believe this can be closed.

Actually, comment #12 was about the .desktop file.

Can we remove icon.xpm from the builds as per comment #3?  I see that the PNG files are in the drops and that's all that is used for Linux-GTK.
Comment 17 Ben Konrath CLA 2007-01-15 16:32:20 EST
Could the request in comment #16 be fixed for 3.3M5? Thanks.
Comment 18 Ben Konrath CLA 2007-09-04 12:50:26 EDT
Ping :) 

Any chance somebody can deal with this? Thanks, Ben
Comment 19 Kim Moir CLA 2008-01-16 11:58:47 EST
Created attachment 87062 [details]
patch

to remove icon.xpm from linux builds
Comment 20 Kim Moir CLA 2008-01-16 21:29:03 EST
Fixed in builds >= N20080116-0010.
Comment 21 Kim Moir CLA 2008-02-11 08:54:20 EST
Bogdan, this is the bug I mentioned on Friday.
Comment 22 Markus Knauer CLA 2008-04-18 05:34:02 EDT
*** Bug 227711 has been marked as a duplicate of this bug. ***
Comment 23 David Williams CLA 2008-04-18 08:00:49 EDT
So, the PNG file's were not put in? 

Even if not automatically associated, I always "manually" associate these icons with what ever launcher I create on Linux, so seems useful to me. 

Comment 24 Jochen Wiedmann CLA 2008-05-11 21:24:21 EDT
I suggest to reopen this bug.

Obviously, the .xpm file has been removed. But no .png files have been added. In other words, there is currently no possibility to add an Eclipse icon for a custom launcher on Linux.

Comment 25 Kim Moir CLA 2008-05-13 14:51:04 EDT
Andrew, would you consider adding the icon.png in the second attachment to the linux directories in the org.eclipse.equinox.executable project (same directories as icon.xpm).  I would then update the builder to include them.
Comment 26 Hendrik Maryns CLA 2008-06-26 09:27:18 EDT
Confirm that this is still a problem with Ganymede build for both x86_64 and i386 Linux.
Comment 27 Corey Puffalt CLA 2008-09-15 11:12:10 EDT
I'm not sure why this bug is marked fixed when there's still no icon provided as noted by other notes on this bug?
Comment 28 Kim Moir CLA 2008-12-09 09:56:05 EST
reopening
Comment 29 Kim Moir CLA 2008-12-09 09:56:30 EST
*** Bug 258073 has been marked as a duplicate of this bug. ***
Comment 30 Andrew Overholt CLA 2008-12-09 10:25:36 EST
Is this blocking on me?  A 48x48 PNG of the icon is attached:

https://bugs.eclipse.org/bugs/attachment.cgi?id=21106

Is there more I can do, Kim?
Comment 31 Kim Moir CLA 2008-12-09 14:19:18 EST
*** Bug 258073 has been marked as a duplicate of this bug. ***
Comment 32 Remy Suen CLA 2008-12-27 08:51:18 EST
*** Bug 259709 has been marked as a duplicate of this bug. ***
Comment 33 Eclipse Genie CLA 2018-10-29 15:37:57 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 34 Alexander Kurtakov CLA 2018-11-12 03:02:43 EST
This has long been fixed.