Bug 86625 - [KeyBindings] registry: acceleratorSets don't work in 3.0
Summary: [KeyBindings] registry: acceleratorSets don't work in 3.0
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-25 09:37 EST by Douglas Pollock CLA
Modified: 2019-09-06 16:12 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Pollock CLA 2005-02-25 09:37:41 EST
I have realized that acceleratorSets didn't work in 3.0.  They are not parsed
correctly by the Persistence class.

The acceleratorSets extension point was introduced in 2.0, and deprecated in
2.1.   It has been replaced with the commands extension point.  The extension
point was parsed correctly in 2.1.x and earlier.

I believe there are three separate options.
1.) Go back to the 2.1.x code and find the acceleratorSets parsing code.  Copy
it into 3.1.
2.) Remove the acceleratorSets extension point and mark it as a breaking change
in 3.1.
3.) Leave the extension point, but leave do not provide any code to parse it. 
Wait for someone to complain.


My general impression is to go for (2).  There are no bugs filed about its
absence yet, and my feeling is that no one misses it.  By removing the extension
point, anyone who happens to use it would see compiler errors.  The note about
breaking changes would give people using it a pointer as to where they should
look.  (As a note, it does not break binary compatibility -- referencing
extension points that don't exist does not cause errors at run-time.)


For now, I'm going implement (3), and wait for some more input on this bug.
Comment 1 Douglas Pollock CLA 2005-05-02 12:02:10 EDT
No comments, and no one has complained.  I'll leave this bug open, but lower its
priority and remove it from the 3.1 time line.
Comment 2 Michael Van Meekeren CLA 2006-04-21 13:14:43 EDT
Moving Dougs bugs
Comment 3 Paul Webster CLA 2006-09-28 15:14:28 EDT
Is this still a problem in 3.3?

PW
Comment 4 Denis Roy CLA 2007-06-22 09:32:48 EDT
Changes requested on bug 193523
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:12:59 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.